feat(superset): add a chart locale parameter - #73
Merged
Conversation
| apiVersion: v1alpha1 | ||
| name: superset | ||
| tag: 6.0.0-p04 | ||
| tag: 6.0.0-p05 |
Contributor
There was a problem hiding this comment.
Suggested change
| tag: 6.0.0-p05 | |
| 1.0.0 # x-release-please-version |
This is to avoid changes related to release workflows
mlahouar
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
localeparameter to the superset package, defaulting toen, plus acurrencyone.D3_FORMATandD3_TIME_FORMATare derived from CLDR through Babel, an existing Superset dependencyTwo free-form parameters,
d3Formatandd3TimeFormat, are merged over the derived values for anything an instance wants to spell differently.locale: enreproduce the current d3 defaults exactly, so existing instances are unaffected.Related Issue
Fixes #72
Type of Change
How to Test
Deploy a Superset Release built from this package with:
On a dashboard
.1%should now display:4,3 %instead of4.3%23/07/2026instead of7/23/2026Checklist