Skip to content

chore(ci): let release-please own the package versions - #74

Open
jpmewenemesse wants to merge 4 commits into
OKDP:mainfrom
jpmewenemesse:chore/release-please
Open

chore(ci): let release-please own the package versions#74
jpmewenemesse wants to merge 4 commits into
OKDP:mainfrom
jpmewenemesse:chore/release-please

Conversation

@jpmewenemesse

@jpmewenemesse jpmewenemesse commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Description

The published version of a package is a literal typed into its manifest

Several consequences of a hand-typed version:

-pNN is not a usable version. Under SemVer a hyphen introduces a
pre-release.

There is no release. Zero git tags, zero GitHub Releases,
.release-please-manifest.json is empty. release-please has been installed the
whole time but configured for the wrong repo shape.

What changes

One release-please component per package, following the pattern already used
in OKDP/helm-charts-utilities. Tags become trino/v1.0.0, each package gets
its own CHANGELOG.md, and separate-pull-requests: false groups them into a
single release pull request.

release-please writes the OCI tag. The generic updater replaces the version
on any line carrying an x-release-please-version annotation.

Every package restarts at 1.0.0. The existing -pNN tags stay on the
registry; nothing is deleted.

Publishing is triggered by a release, for the released packages only.
release-please.yml passes paths_released to the package template, which
resolves each released directory to its manifest.

Shared charts are guarded. airflow, superset and trino embed
charts/internal-secrets by relative path, and jupyterhub embeds
charts/oidc-client. release-please assigns commits to packages by directory,
and charts/ sits outside every package, so a charts-only change would release
nothing and never reach the registry.

Related Issue

Fixes #68

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / chore
  • Breaking change

How to Test

Checklist

  • I have tested my changes
  • Documentation updated if needed
  • If breaking change: migration path described above
  • I hereby declare this contribution to be licensed under the Apache License Version 2.0.
  • I hereby agree to grant TOSIT a copyright license to use my contributions.

… updated each package tag line the bot should update and updated workflows to considere release workflow
@jpmewenemesse

jpmewenemesse commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

#18 must be closed before this one because there is no per package unit release and it does not make any sense

@jpmewenemesse jpmewenemesse changed the title Chore/release workflow chore/release workflow Aug 31, 2026
@jpmewenemesse jpmewenemesse changed the title chore/release workflow chore(ci): let release-please own the package versions Sep 1, 2026
@jpmewenemesse
jpmewenemesse marked this pull request as ready for review September 2, 2026 10:18
@jpmewenemesse
jpmewenemesse requested review from a team September 2, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derive the published package version from a release instead of a hand-edited tag

1 participant