fix(airflow): give dagsGitSync a typed schema instead of free-form keys - #77
Open
abir-oumghar wants to merge 1 commit into
Open
fix(airflow): give dagsGitSync a typed schema instead of free-form keys#77abir-oumghar wants to merge 1 commit into
abir-oumghar wants to merge 1 commit into
Conversation
Contributor
Author
|
Depends on #108 (object-fields widget), merge and release that one first, otherwise this falls back to the YAML editor. |
abir-oumghar
force-pushed
the
fix/airflow-gitsync-schema
branch
from
September 1, 2026 13:53
d3a8c09 to
73414db
Compare
abir-oumghar
force-pushed
the
fix/airflow-gitsync-schema
branch
from
September 3, 2026 16:24
73414db to
81d9225
Compare
abir-oumghar
force-pushed
the
fix/airflow-gitsync-schema
branch
from
September 3, 2026 17:13
81d9225 to
9124f98
Compare
| apiVersion: v1alpha1 | ||
| name: airflow | ||
| tag: 3.2.1-p06 | ||
| tag: 3.2.1-p07 |
Contributor
There was a problem hiding this comment.
Suggested change
| tag: 3.2.1-p07 | |
| 1.0.0 # x-release-please-version |
This is to avoid conflicts with changes related to release workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type the
dags.gitSyncvalues by their syntax instead of forcing strings: the field uses thekey-value-scalarwidget, so unquotedtrue/falseis a boolean, an unquoted number is an int/float, and quotes force a string. The keys stay free (additionalProperties: true), so any git-sync value can be set without freezing the options. This fixes the earlier behaviour where every value was a string, and a boolean or a number could not be expressed.Depends on the
key-value-scalarwidget in OKDP/okdp-control-plane-ui#108; merge and release that first.Fixes #76
Type of Change
How to Test
kubocd package airflow.yaml: builds; the manifest carries thekey-value-scalarwidget the console reads.Screenshots
Git sync parameters (deploy wizard), before / after: