Skip to content

Add retry logic for server errors #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-omophub merged 2 commits into from
Mar 19, 2026
Merged

Add retry logic for server errors #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05df251
Add retry logic for server errors in SyncHTTPClient and AsyncHTTPClie…
Mar 18, 2026
b2a98db
Refactor retry condition formatting in SyncHTTPClient and AsyncHTTPCl…
Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/omophub/_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,13 @@ def request(
params=filtered_params if filtered_params else None,
json=json,
)
# Retry on server errors (502, 503, 504)
if (
response.status_code in (502, 503, 504)
and attempt < self._max_retries
):
time.sleep(2**attempt * 0.5)
continue
return response.content, response.status_code, response.headers

except httpx.ConnectError as e:
Expand Down Expand Up @@ -222,6 +229,13 @@ async def request(
params=filtered_params if filtered_params else None,
json=json,
)
# Retry on server errors (502, 503, 504)
if (
response.status_code in (502, 503, 504)
and attempt < self._max_retries
):
await asyncio.sleep(2**attempt * 0.5)
continue
return response.content, response.status_code, response.headers

except httpx.ConnectError as e:
Expand Down
Loading