Skip to content

test(native-app): avoid chmodding timeout socket#59

Open
leno23 wants to merge 1 commit into
OMT-Global:mainfrom
leno23:fix-macos-socket-timeout-test-41
Open

test(native-app): avoid chmodding timeout socket#59
leno23 wants to merge 1 commit into
OMT-Global:mainfrom
leno23:fix-macos-socket-timeout-test-41

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 17, 2026

Summary

  • Avoid chmodding the Unix socket path in the native-app timeout regression test.
  • Bind the test socket under a temporary restrictive umask so the socket is created with owner-only permissions on platforms like macOS where chmod on sockets returns EPERM.
  • Keep the test focused on the intended hung-broker timeout behavior.

Closes #41

Testing

  • PKG_CONFIG_PATH=/home/linuxbrew/.linuxbrew/lib/pkgconfig cargo test native_app::tests
  • PKG_CONFIG_PATH=/home/linuxbrew/.linuxbrew/lib/pkgconfig cargo test native_app::tests::socket_request_times_out_when_broker_does_not_reply
  • cargo fmt --check

Merge Automation

Auto-merge is enabled with squash merge. The PR is ready for review and remains blocked until the required review approval is satisfied.

AI assistance disclosure

This PR was prepared with AI assistance and manually verified with the commands above.

@athena-omt athena-omt added area:infra Infrastructure, CI, deployment, and operations work. risk:medium Moderate implementation or operational risk. status:needs-review Needs review before merge or closure. lane:ares review:athena state:draft labels May 17, 2026
@pheidon
Copy link
Copy Markdown
Contributor

pheidon commented May 18, 2026

@leno23 Thanks. This is aligned with #41 and the narrow scope is good.

Before this is reviewable, please harden the temporary umask handling with a guard/RAII pattern so the process-global umask is always restored even if the helper changes later. After that, I’ll run CI and validate the macOS timeout test path.

@pheidon pheidon force-pushed the fix-macos-socket-timeout-test-41 branch from c512d70 to 901b01b Compare May 19, 2026 00:11
@pheidon pheidon marked this pull request as ready for review May 19, 2026 00:11
@pheidon pheidon requested review from jmcte and pheidon as code owners May 19, 2026 00:11
@pheidon pheidon enabled auto-merge (squash) May 19, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:infra Infrastructure, CI, deployment, and operations work. lane:ares review:athena risk:medium Moderate implementation or operational risk. state:waiting-checks status:needs-review Needs review before merge or closure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix native-app socket timeout regression test on macOS

4 participants