test(native-app): avoid chmodding timeout socket#59
Open
leno23 wants to merge 1 commit into
Open
Conversation
Contributor
|
@leno23 Thanks. This is aligned with #41 and the narrow scope is good. Before this is reviewable, please harden the temporary umask handling with a guard/RAII pattern so the process-global umask is always restored even if the helper changes later. After that, I’ll run CI and validate the macOS timeout test path. |
c512d70 to
901b01b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #41
Testing
PKG_CONFIG_PATH=/home/linuxbrew/.linuxbrew/lib/pkgconfig cargo test native_app::testsPKG_CONFIG_PATH=/home/linuxbrew/.linuxbrew/lib/pkgconfig cargo test native_app::tests::socket_request_times_out_when_broker_does_not_replycargo fmt --checkMerge Automation
Auto-merge is enabled with squash merge. The PR is ready for review and remains blocked until the required review approval is satisfied.
AI assistance disclosure
This PR was prepared with AI assistance and manually verified with the commands above.