fix: avoid name collision on cpp files#379
Closed
mlecoq wants to merge 1 commit intoOP-Engineering:mainfrom
Closed
fix: avoid name collision on cpp files#379mlecoq wants to merge 1 commit intoOP-Engineering:mainfrom
mlecoq wants to merge 1 commit intoOP-Engineering:mainfrom
Conversation
mlecoq
force-pushed
the
fix_nameCollision
branch
from
8fcf55c to
04fd389
Compare
mlecoq
force-pushed
the
fix_nameCollision
branch
from
04fd389 to
aba47b0
Compare
Author
|
finally closing it in favor of changes on quick crypto side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is a collision detected on utils.hpp when op-sqlite and react-native-quick-crypto are both installed (see margelo/react-native-quick-crypto#834 (comment)) so I have moved cpp files under a subdirectory to avoid this (I think I will open a PR on quick-crypto too)