Skip to content

[HYRAX-1868] Turn Checksums on all the time the NGAP service. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndp-opendap merged 3 commits into from
Sep 9, 2025
Merged

[HYRAX-1868] Turn Checksums on all the time the NGAP service. #242

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bc9e7c
Wip
ndp-opendap Sep 9, 2025
7498d0e
* Tweaked checksums ON change to only apply to DAP=4 Data Responses a…
ndp-opendap Sep 9, 2025
6dc94af
* Tweaked checksums for DMR-only response to work on request
ndp-opendap Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/opendap/ngap/NgapBesApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,16 @@ public Document getDap4RequestDocument(User user,

addEdlAuthToken(request,user);

if(qp.computeChecksums())
request.addContent(setContextElement(DAP4_CHECKSUMS_CONTEXT,"true"));

// @FIXME - THIS IS WHERE WE WOULD INVOKE OPTIONAL CHECKSUMS, BUT WE ARE MAKING THEM MANDATORY TO
// ACCOMMODATE BROKEN CLIENT CODE THAT EXPECTS THEM TO AWLAYS BE THERE. THIS WILL BREAK getdap4
// AND ALL OF THE ASSOCIATED TESTS BECAUSE AT THE TIME THIS IS WRITTEN THERE IS NO WAY FOR A
// FOR A CLIENT TO KNOW THAT A DAP4 DATA RESPONSE CONTAINS CHECKSUMS.
//
// if(qp.computeChecksums())
if(type.equalsIgnoreCase(DAP4_DATA) ||
(type.equalsIgnoreCase(DAP4_DMR) && qp.computeChecksums()) ) {
request.addContent(setContextElement(DAP4_CHECKSUMS_CONTEXT, "true"));
}
request.addContent(setContainerElement(getBesContainerName(),
getBesSpaceName(),remoteDataSourceUrl,type));

Expand Down