#14213 HDF5Exporter: Guard null m_hdfFile in createGroup#14214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14213
Problem
When
new H5::H5Filethrows in theRifHdf5Exporterconstructor, the exception is swallowed andm_hdfFileis left null (#13883 made this reliable).createGroup( nullptr, ... )then dereferences the nullm_hdfFile; the surroundingtry/catch(...)cannot catch the resulting SIGSEGV. This crashes HDF5 summary export when the target file cannot be created (unwritable directory, locked file, disk full, invalid path).Fix
Guard the
elsebranch withm_hdfFilebefore dereferencing, matching the existingparentGroupnull check in the same function. On failure an emptyH5::Groupis returned, which callers already handle (writeDatasetwrapscreateDataSetintry/catch).