Add CO2SOL and H2SOL for regression#6952
Merged
totto82 merged 1 commit intoOPM:masterfrom Apr 16, 2026
Merged
Conversation
Member
Author
|
jenkins build this update_data please |
jenkins4opm
pushed a commit
to jenkins4opm/opm-tests
that referenced
this pull request
Mar 19, 2026
Reason: PR OPM/opm-simulators#6952 opm-common = 3e248268e90ef38c752b1f41a0c92a8b86b9c9ac opm-grid = 21f4c65c17f32602dd78f18eb08e093bd0a0994c opm-simulators = 8f0762e3b9c12a1b0b3e0ad9153cd2bafc283d49 ### Changed Tests ### * spe1_co2sol * spe1_h2sol
Member
Author
|
jenkins build this opm-tests=1511 please |
3 similar comments
Member
Author
|
jenkins build this opm-tests=1511 please |
Member
Author
|
jenkins build this opm-tests=1511 please |
Member
Author
|
jenkins build this opm-tests=1511 please |
svenn-t
approved these changes
Apr 15, 2026
Contributor
svenn-t
left a comment
There was a problem hiding this comment.
Thanks for adding CO2SOL/H2SOL tests. This can be merged.
Food for thought: should we add enable-opm-rst-file=true arguments to these and other tests like CO2STORE and H2STORE? Otherwise, outputs like RSW, RVW, etc. will not be compared, as I understand it.
Member
Author
|
Yes we should. I will update accordingly and merge afterward. |
Member
Author
|
jenkins build this update_data please |
jenkins4opm
pushed a commit
to jenkins4opm/opm-tests
that referenced
this pull request
Apr 16, 2026
Reason: PR OPM/opm-simulators#6952 opm-common = 65e3d1a5f20bf13425299d4e02ae278d93a714e9 opm-grid = 25b665010d3bb788c313d440ff2eee993b00535a opm-simulators = 80224806d7481fe7d8950eb60a506bf5249c7eae ### Changed Tests ### * spe1_co2sol * spe1_h2sol * spe1_gaswater_solvent
Member
Author
|
jenkins build this update_data please |
jenkins4opm
pushed a commit
to jenkins4opm/opm-tests
that referenced
this pull request
Apr 16, 2026
Reason: PR OPM/opm-simulators#6952 opm-common = 6a8e8368c5f63be9ac18b39232d7aebcfb7db8a4 opm-grid = 25b665010d3bb788c313d440ff2eee993b00535a opm-simulators = 73d3d00090ba78eaad6245f36ad2059140ea5787 ### Changed Tests ### * spe1_h2sol * spe1_co2sol
Member
Author
|
jenkins build this opm-tests=1511 please |
Member
Author
|
jenkins build this opm-tests=1518 please |
totto82
added a commit
to OPM/opm-tests
that referenced
this pull request
Apr 16, 2026
Automatic Reference Data Update for PR OPM/opm-simulators#6952
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.