Support nested build directories in sibling search#6961
Open
hakonhagland wants to merge 1 commit intoOPM:masterfrom
Open
Support nested build directories in sibling search#6961hakonhagland wants to merge 1 commit intoOPM:masterfrom
hakonhagland wants to merge 1 commit intoOPM:masterfrom
Conversation
The inline sibling search logic used get_filename_component(NAME) to extract the build directory name, which only returned the last path component. This broke sibling discovery for nested build directories like "builds/debug" — the search would look for "../opm-common/debug" instead of "../opm-common/builds/debug". Use file(RELATIVE_PATH) to compute the full relative path from PROJECT_SOURCE_DIR to PROJECT_BINARY_DIR, then apply that same relative path to the sibling module's source tree. This correctly handles build directories at any depth. The previous strategies (prefix-based naming and common build root) are kept as fallbacks for out-of-source builds. This is the inline copy of the logic in opm-common/cmake/Modules/OpmSiblingSearch.cmake, duplicated here because opm-common must be located before its cmake modules become available via find_package.
hakonhagland
added
the
manual:irrelevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See description in the companion PR in opm-common: OPM/opm-common#5091