[LGR] Pass in writeInitial an NNCCollection to allow output of the 3 NNC types#6972
Open
aritorto wants to merge 1 commit intoOPM:masterfrom
Open
[LGR] Pass in writeInitial an NNCCollection to allow output of the 3 NNC types#6972aritorto wants to merge 1 commit intoOPM:masterfrom
aritorto wants to merge 1 commit intoOPM:masterfrom
Conversation
aritorto
added
the
manual:irrelevant
Member
Author
|
jenkins build this serial please |
Member
Author
|
jenkins build this serial please |
aritorto
force-pushed
the
bridgeNNCs
branch
3 times, most recently
from
d34218c to
668a31a
Compare
…pes, in CpGrid with LGRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR invokes the bridge between simulation NNCs and NNCCollection for output files, implemented in OPM/opm-common#5089.
With this change, all three NNC types get written out.
To test this functionality, run the simulation in serial mode with:
--parsing-strictness=low
--enable-ecl-output=true
Draft mode since it seems that some throw statements might need to be removed in NNCCollection::getGlobalNNC()