fix(DEN-1606): bind clone build transport and identity on current dev - #772
Draft
ORESoftware wants to merge 6 commits into
Draft
fix(DEN-1606): bind clone build transport and identity on current dev#772ORESoftware wants to merge 6 commits into
ORESoftware wants to merge 6 commits into
Conversation
Retain only the reviewed temporary finalizer and deterministic transformation script on top of current dev, discarding stale pre-capacity transport history before exact-target validation.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconstruct the reviewed clone-server build transport and identity boundary directly on the current
devbranch, after the atomic run-reservation merge.This successor avoids replaying the conflicted history in #759. A same-repository one-shot finalizer applies only the reviewed transformation, runs pinned Rust formatting, warnings-denied Clippy, and every clone-server target/test, then deletes both temporary builder files and leaves exactly six product files.
Product boundary
GHA_CLONE_BUILD_SERVER_URLas a credential-free origin;dev.Tests
The finalizer runs:
The product adds unit regressions for safe/unsafe origins, exact Kubernetes DNS forms, redirect refusal, accepted ID bounds, and status identity binding, while updating real-process fixtures to use positive polling values.
Temporary files
Until the finalizer succeeds this draft contains:
.github/workflows/den-1606-build-transport-v3-finalize-once.ymlscripts/finalize-den-1606-build-transport.pyThey are required to disappear before review. The final diff is hard-limited to the trust-boundary document,
main.rs, and four existing process-test files.Supersedes conflicted PR #759 after successful exact-head CI.
Linear: DEN-1606
Related: DEN-1635, DEN-1550, DEN-1597, DEN-1549