Oti spike - #36
Closed
Samm-Py wants to merge 4 commits into
Closed
Conversation
Finch's field type was fixed to double. This threads a Scalar template parameter (defaulting to double) through Grid, Boundary, Solver, Layer and SolidificationData, so the temperature field can carry a user-supplied arithmetic type. With double the generated code and results are unchanged; verified bit-identical solidification output on the single_line case. The differentiated material and source inputs move into a MaterialProperties struct so a caller can supply values of the field scalar type rather than plain doubles read from the input deck. Quantities that only select a branch (solidus, liquidus) and all mesh geometry stay double. Finch_Scalar.hpp adds exp/fmin/fmax dispatch: arithmetic types forward to Kokkos as before, anything else resolves by ADL into the scalar type's own namespace. Finch therefore carries no dependency on any AD library. The optional finch_sensitivity application demonstrates the result with cpp_oti_lib, obtaining d(QoI)/dp for six material and source parameters from a single solve and validating each against central finite differences. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PNkQTS2g7P6dNDybhWRkwz
Documents every change made, both compile errors hit, the environment setup cost kept separate from the integration cost, and the finite-difference step-size investigation that initially looked like a 28% derivative error and turned out to be an artifact of the latent-heat branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PNkQTS2g7P6dNDybhWRkwz
The measured changes are the level-of-effort evidence; projected schedules added nothing. Remaining work is now recorded as concrete tasks, with the open numerical questions kept alongside them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PNkQTS2g7P6dNDybhWRkwz
Author
|
Closed because this was opened from the wrong branch; changes continued in #35. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.