Add wrapper Makefiles to benchmarks with subdir builds#213
Merged
zjin-lcf merged 2 commits intoORNL:masterfrom May 1, 2026
Merged
Add wrapper Makefiles to benchmarks with subdir builds#213zjin-lcf merged 2 commits intoORNL:masterfrom
zjin-lcf merged 2 commits intoORNL:masterfrom
Conversation
Collaborator
|
I have a question about HIP_ARCH. It is not set in non-wrapper Makefiles. If HIP_ARCH is added, then do all Makefiles in HIP programs need to set it ? |
Contributor
Author
Ah, sorry, that's actually a convenience for my setup. It doesn't do any harm, but I will remove it. |
Contributor
Author
|
Removed in 2f94f83. |
Collaborator
|
Thank you for the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #212.