[snicit-hip] Add <cstring> header for memset#215
Closed
maarquitos14 wants to merge 1 commit intoORNL:masterfrom
Closed
[snicit-hip] Add <cstring> header for memset#215maarquitos14 wants to merge 1 commit intoORNL:masterfrom
maarquitos14 wants to merge 1 commit intoORNL:masterfrom
Conversation
zjin-lcf
added a commit
to zjin-lcf/HeCBench
that referenced
this pull request
May 1, 2026
Collaborator
|
Thank you for the pull request. I didn't merge your PR but updated the programs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SNICIT.hpp calls memset on a host pointer (line 239) but doesn't include
<cstring>. Without it, hipcc's transitive includes can resolve memset to a__device__-only intrinsic, breaking the host compile. Add the standard header to make the host declaration explicit.