refactor: extract DEFAULT_BATCH_SIZE and DEFAULT_SEARCH_DEPTH to named constants#440
Merged
sonukapoor merged 2 commits intoMay 25, 2026
Conversation
coder-Yash886
force-pushed
the
feature/issue-436-extract-default-constants
branch
from
becbb92 to
33791ca
Compare
Contributor
Author
|
@sonukapoor please review the PR when you have free time |
sonukapoor
approved these changes
May 25, 2026
Collaborator
sonukapoor
left a comment
sonukapoor
left a comment
There was a problem hiding this comment.
Clean extraction - the constants are well-named and the values match the originals exactly. No logic changes. Good contribution.
Contributor
Author
|
Thanks for the kind words! Happy to keep contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436
Changes
DEFAULT_BATCH_SIZE = 100andDEFAULT_SEARCH_DEPTH = 4tosrc/constants.tssrc/index.tsto include both new constants100and4with the named constantsNo logic changes — values remain the same.