Repository navigation
fix: cap PyAV below 19 so faster-whisper can decode audio (#127) - #130
Draft
raphaelm22 wants to merge 2 commits into
Draft
raphaelm22 wants to merge 2 commits into
raphaelm22 wants to merge 2 commits into
Conversation
…tSecure#127) PyAV 19 removed the metadata_errors kwarg that faster-whisper 1.2.1's decode_audio still passes, so every plain-pip install failed its first transcription with "open() got an unexpected keyword argument 'metadata_errors'". uv users were unaffected: uv.lock pins av 17.1.0. Name av directly in requirements.txt and pyproject.toml with a <19 cap (18.1.0 verified working, 19.0.0 verified broken). The uv.lock change is only the two new direct-dependency entries: resolved versions are unchanged and `uv lock --check` passes. Closes ObscureAintSecure#127
…ntSecure#127) The suite mocks faster-whisper (torch DLL gotcha) and the import smoke never decodes audio, so the PyAV 19 break was invisible to CI even though the test job installs through the exact pip path that broke. Decode one second of silence with faster_whisper.decode_audio after installing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avdirectly inrequirements.txtandpyproject.tomlwith>=11,<19. It is a transitive dependency of faster-whisper. PyAV 19 dropped themetadata_errorskwarg that faster-whisper 1.2.1'sdecode_audiostill passes, so every plain-pip install fails its first transcription (Transcription fails on plain-pip installs: PyAV 19 removedmetadata_errors(pinav<19) #127).uv.lock: only the two new direct-dependency entries. No resolved version changes.uv lock --checkpasses with uv 0.12.7 and 0.13.0.faster_whisper.decode_audioon a 1 s WAV after the pip install. The suite mocks faster-whisper and the import smoke never decodes audio, so CI could not see this break.packaging-and-launch.mddocuments the transitive-dependency pattern and the new CI step.Verification
av==18.1.0acceptsav.open(..., metadata_errors="ignore").av==19.0.0raisesTypeError, so the cap is<19.av==17.1.0in a plain-pip venv, a real 7.5 min recording transcribes (large-v3-turbo, pt) and diarizes normally.A note on
uv.lockRegenerating with the newest uv (0.13.0) bumps the lock
revisionfrom 3 to 5 and re-resolvesonnxruntimein one fork. uv 0.12.7, current when the lock was last written, only reorders resolution markers. To keep the diff limited to the actual change, I added the two entries on top of master's lock and verified them withuv lock --checkon both versions. I can commit a full regeneration instead if you prefer.Closes #127
🤖 Generated with Claude Code