Skip to content

[config] v1.3 config fields, state file extension, new deps#17

Merged
Obsidian68 merged 1 commit intofeat/integrationfrom
feat/v1.3-config
May 3, 2026
Merged

[config] v1.3 config fields, state file extension, new deps#17
Obsidian68 merged 1 commit intofeat/integrationfrom
feat/v1.3-config

Conversation

@Obsidian68
Copy link
Copy Markdown
Owner

Summary

  • Bump version to 1.3.0 in __init__.py and pyproject.toml
  • Add 4 new Settings fields: watcher_enabled (True), watcher_debounce_ms (2000), mcp_enabled (True), mcp_path ("/mcp")
  • Extend _write_state() with last_indexed: str | None = None — backward compatible, existing call sites unchanged
  • Add fastmcp>=2.0.0 and watchfiles>=0.21.0 dependencies
  • Add 4 new env vars to .env.example
  • Add config tests for new field defaults and env overrides
  • Add CLI tests for last_indexed round-trip and backward compatibility

Test plan

  • 283 tests pass, 92.65% coverage (threshold: 90%)
  • Ruff lint: clean
  • Ruff format: clean
  • Zero TODOs, dead code, hardcoded secrets
  • New config fields load with correct defaults
  • New config fields override from environment
  • last_indexed round-trips through state file
  • State files without last_indexed still work (backward compat)

Known limitations

  • watcher_enabled, watcher_debounce_ms, mcp_enabled, mcp_path are accepted but unused — implementation comes in feat/mcp-server and feat/file-watcher branches
  • last_indexed in state file is written but not yet consumed — feat/file-watcher will use it for incremental vault scanning
  • uv.lock was auto-updated by uv sync to include fastmcp and watchfiles transitive dependencies

🤖 Generated with Claude Code

- Bump version to 1.3.0
- Add 4 new Settings fields: watcher_enabled, watcher_debounce_ms, mcp_enabled, mcp_path
- Extend _write_state() with last_indexed parameter for incremental vault scanning
- Add fastmcp>=2.0.0 and watchfiles>=0.21.0 dependencies
- Add env vars for new config fields in .env.example
- Add config tests for new field defaults and env overrides
- Add CLI tests for last_indexed round-trip and backward compatibility

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f5941a5c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/engram/__init__.py
@@ -1 +1 @@
__version__ = "1.2.0"
__version__ = "1.3.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update API version constants to 1.3.0

This commit bumps __version__ to 1.3.0, but the REST API metadata and health payload still report 1.2.0 (src/engram/interfaces/rest/app.py:33, src/engram/interfaces/rest/health.py:35), so after upgrading, clients that read /health or OpenAPI version fields will see a stale version and can make incorrect compatibility decisions. Please keep all externally reported version strings in sync with the package version bump.

Useful? React with 👍 / 👎.

@Obsidian68 Obsidian68 merged commit 3d48653 into feat/integration May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant