[config] v1.3 config fields, state file extension, new deps#17
[config] v1.3 config fields, state file extension, new deps#17Obsidian68 merged 1 commit intofeat/integrationfrom
Conversation
- Bump version to 1.3.0 - Add 4 new Settings fields: watcher_enabled, watcher_debounce_ms, mcp_enabled, mcp_path - Extend _write_state() with last_indexed parameter for incremental vault scanning - Add fastmcp>=2.0.0 and watchfiles>=0.21.0 dependencies - Add env vars for new config fields in .env.example - Add config tests for new field defaults and env overrides - Add CLI tests for last_indexed round-trip and backward compatibility Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f5941a5c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| __version__ = "1.2.0" | |||
| __version__ = "1.3.0" | |||
There was a problem hiding this comment.
Update API version constants to 1.3.0
This commit bumps __version__ to 1.3.0, but the REST API metadata and health payload still report 1.2.0 (src/engram/interfaces/rest/app.py:33, src/engram/interfaces/rest/health.py:35), so after upgrading, clients that read /health or OpenAPI version fields will see a stale version and can make incorrect compatibility decisions. Please keep all externally reported version strings in sync with the package version bump.
Useful? React with 👍 / 👎.
Summary
__init__.pyandpyproject.tomlwatcher_enabled(True),watcher_debounce_ms(2000),mcp_enabled(True),mcp_path("/mcp")_write_state()withlast_indexed: str | None = None— backward compatible, existing call sites unchangedfastmcp>=2.0.0andwatchfiles>=0.21.0dependencies.env.examplelast_indexedround-trip and backward compatibilityTest plan
last_indexedround-trips through state filelast_indexedstill work (backward compat)Known limitations
watcher_enabled,watcher_debounce_ms,mcp_enabled,mcp_pathare accepted but unused — implementation comes in feat/mcp-server and feat/file-watcher brancheslast_indexedin state file is written but not yet consumed — feat/file-watcher will use it for incremental vault scanninguv.lockwas auto-updated byuv syncto include fastmcp and watchfiles transitive dependencies🤖 Generated with Claude Code