CU-869d9w22a Enhance order label panel shipment header, label AJAX, and tests#3
CU-869d9w22a Enhance order label panel shipment header, label AJAX, and tests#3tasselchof wants to merge 2 commits into
Conversation
…nd tests Prominent shipment ref and badge-style status/COD in the connect toolbar; label-related admin endpoints and PHPUnit coverage updates. Co-authored-by: Cursor <cursoragent@cursor.com>
- Improved the shipment header display and badge-style status in the connect toolbar. - Updated label-related admin endpoints for better performance. - Enhanced PHPUnit tests to cover new label functionalities. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 198ef8b6e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| wp_enqueue_script( | ||
| 'octavawms-pdfjs', | ||
| plugins_url('assets/vendor/pdfjs/3.11.174/pdf.min.js', $pluginMain), | ||
| [], |
There was a problem hiding this comment.
This enqueue points to assets/vendor/pdfjs/3.11.174/pdf.min.js, but this commit does not add that vendor directory (nor the worker file referenced in localized config), so the script 404s on every install; as a result pdfjsLib is undefined and the new label preview/zoom path in admin-order-panel.js never becomes functional. Users can still download labels, but the newly introduced in-panel viewer is effectively broken in production.
Useful? React with 👍 / 👎.
1 participant
Summary
LabelAjax,LabelMetaBox,AdminLabelActions) and expanded PHPUnit coverage.ClickUp
https://app.clickup.com/t/869d9w22a
Test plan
composer check(lint + PHPUnit) — passed locally before commit.Notes
assets/vendor/was not included in this commit; add or gitignore if PDF.js assets should ship with the plugin.Made with Cursor