Improve extension architecture helpers - #59
Merged
Kingson4Wu merged 2 commits intoSep 1, 2026
Merged
Conversation
Kingson4Wu
deleted the
loop/fluent-frame/harness-auto/1788201000000-fluent-frame-harness-auto
branch
September 1, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness assessment
1788201000000-fluent-frame-harness-autodev93/95.Selected subtasks
Skipped or no-op subtasks
pnpm audit --audit-level highreported no known vulnerabilities and no reachable high-signal security issue was confirmed.Changes
apps/extension/src/chromeRuntimeErrors.tsand regression tests for reload-context error detection.content.tsandlearningGenerationClient.tsto use the shared runtime error helper without changing user-facing error messages.apps/extension/src/popupRelativeTime.tsand regression tests for invalid, future, seconds, minutes, hours, and queue minute-only behavior.popupQueue.tsandpopupLibrary.tsto use the shared popup formatter while preserving existing displayed copy.Verification
pnpm run typecheckpassed.pnpm testpassed: shared 42 tests, extension 150 tests, native-host 132 tests, scripts 48 tests.pnpm audit --audit-level highpassed with no known vulnerabilities.93/95.loop/fluent-frame/harness-auto/1788201000000-fluent-frame-harness-auto.Remaining risk
95was not reached because the assessment script continues to emit generic guarded architecture slice prompts after the accepted slices.