Skip to content

fix: create server runtime error #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OfrenDialsa merged 1 commit into from
Dec 12, 2025
Merged

fix: create server runtime error #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ jobs:
script: |
cd ~/ForumAPI
git pull origin main
npm install
npm run migrate up
pnpm install
pnpm migrate up
pm2 restart forum-api
8 changes: 2 additions & 6 deletions src/Infrastructures/http/createServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,13 @@ const createServer = async (container) => {
}

server.ext("onPreResponse", (request, h) => {
// mendapatkan konteks response dari request
const { response } = request;

if (response instanceof Error) {
// bila response tersebut error, tangani sesuai kebutuhan
console.error(response); // <-- tambahkan ini agar error asli muncul

const translatedError = DomainErrorTranslator.translate(response);

// penanganan client error secara internal.
if (translatedError instanceof ClientError) {
const newResponse = h.response({
status: "fail",
Expand All @@ -100,12 +99,10 @@ const createServer = async (container) => {
return newResponse;
}

// mempertahankan penanganan client error oleh hapi secara native, seperti 404, etc.
if (!translatedError.isServer) {
return h.continue;
}

// penanganan server error sesuai kebutuhan
const newResponse = h.response({
status: "error",
message: "terjadi kegagalan pada server kami",
Expand All @@ -114,7 +111,6 @@ const createServer = async (container) => {
return newResponse;
}

// jika bukan error, lanjutkan dengan response sebelumnya (tanpa terintervensi)
return h.continue;
});

Expand Down