Repository navigation
refactor: tag kill plans as range or orphan - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kill plans are tagged by kind. An orphan plan has no port names, so it can't be built with any.
Also:
ListenerScan(mac): an lsof address listed before anypline getspid: nullinstead of a fake pid0.ProcessTree.killTreedrops its unusedplatformparam and readsprocess.platform.Evidence
n*:21000\np42\nn*:21001→{ port: 21000, pid: 0 }; nothing tested which kills look for leeway-run parents.After: →
{ port: 21000, pid: null };RangeKill.killsRunstests: a range plan →true, orphan-port and orphans plans →false.pnpm verify: green (274 passed, 3 skipped).pnpm test:linux: not run locally (podman not on PATH), so it rests on CI.Merge Danger
Door: two-way
Blast Radius: none
KillPlanis internal to the CLI. Theleeway killoutput is unchanged.