Update dependency starlette to ~=1.3.1 [SECURITY]#92
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
8e1b05b to
81da88c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
~=1.0.0→~=1.3.1Starlette: Arbitrary HTTP method dispatched to
HTTPEndpointattributes viagetattrCVE-2026-48817 / GHSA-x746-7m8f-x49c
More information
Details
Summary
When dispatching a request,
HTTPEndpointselects the handler by lowercasing the HTTP method and looking it up as an attribute withgetattr, without restricting the lookup to a known set of HTTP verbs.When an
HTTPEndpointsubclass is registered throughRoute(...)without an explicitmethods=argument, the route does not constrain the method and every method reaches the endpoint. If a non-standard HTTP method whose lowercased name matches an attribute on the endpoint subclass reaches the endpoint, that attribute is invoked as if it were a request handler. An attacker can use this to reach methods that were never meant to be HTTP handlers, such as internal helpers, without the authorization checks applied by the intended public handler.Details
HTTPEndpointuses the client-supplied method name to resolve an instance attribute, without validating it against the set of HTTP verbs the endpoint supports. A method such as_DO_DELETEtherefore resolves an attribute like_do_deleteand invokes it. Non-standard methods are valid RFC 9110 token methods, so an endpoint must not treat the method name as a trusted attribute selector.Impact
An application is affected when all of the following hold:
HTTPEndpointsubclass and registers it viaRoute(...)without an explicitmethods=argument.requestargument and return a response.This also affects frameworks built on Starlette, like FastAPI.
Mitigation
Register
HTTPEndpointsubclasses with an explicitmethods=argument on theRoute, listing only the HTTP verbs the endpoint supports. The route then rejects any other method with405 Method Not Allowedbefore it reaches the endpoint, so non-standard methods cannot resolve an attribute.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Starlette: SSRF and NTLM credential theft via UNC paths in StaticFiles on Windows
CVE-2026-48818 / GHSA-wqp7-x3pw-xc5r
More information
Details
Summary
When serving static files on Windows,
StaticFilesresolves the requested path withos.path.realpath. If a UNC path (such as\\attacker.com\share) reaches the resolver,realpathcauses the process to open a connection to the remote host over SMB (port 445). This is a server-side request forgery (SSRF) that leaks the service account's NTLMv2 credentials to the attacker-controlled host, which can then be cracked offline or relayed to other hosts.Details
StaticFiles.lookup_path()joins the requested path onto the served directory and callsos.path.realpathon the result before checking containment withos.path.commonpath. On Windows, a UNC path is absolute, soos.path.joindiscards the served directory andrealpathresolves the bare UNC path, triggering the outbound SMB connection and NTLM authentication before the containment check rejects the path. The HTTP response is a benign 404, but the credential disclosure has already happened. POSIX systems are not affected.This only affects the default configuration (
follow_symlink=False), which usesos.path.realpath. Thefollow_symlink=Truebranch usesos.path.abspath, which performs no I/O.Impact
Applications running on Windows that serve files with
StaticFiles(directly, or via a framework built on Starlette such as FastAPI) in the default configuration are affected.StaticFilesis typically unauthenticated, so any client can trigger the SMB connection and leak the service account's NTLMv2 hash. A secondary impact is discovering internal hosts reachable over SMB by timing responses for valid versus invalid addresses.Mitigation
Applications not running on Windows are not affected. On Windows, serving static files through a dedicated web server (such as nginx or IIS) instead of
StaticFilesavoids the issue. Blocking outbound SMB (port 445) from the application host prevents the credential disclosure even if a UNC path is resolved.Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Starlette: Unvalidated request path concatenated into authority poisons request.url.hostname
CVE-2026-54282 / GHSA-jp82-jpqv-5vv3
More information
Details
Summary
In affected versions, the HTTP request path is not validated before being used to reconstruct
request.url. Becauserequest.urlis rebuilt by concatenating{scheme}://{host}{path}and re-parsing the result, a path that does not begin with/(for example@google.com) moves the authority boundary during re-parsing, sorequest.url.hostnameandrequest.url.netlocbecome attacker-controlled. Code that readsrequest.url.hostname(rather than theHostheader orscope) can therefore be misled into trusting an attacker-supplied host.Details
When a client requests a path that does not start with
/:affected versions reconstruct the URL as
http://localhost@google.com. Per RFC 3986 §3.2.1, the substring before@in the authority isuserinfo, so re-parsing yieldsusername = "localhost"andhostname = "google.com", with an empty path:The root cause is that the path is concatenated directly after the host without a separating
/, and without validating that it begins with one. Only theHostheader was validated when constructingrequest.url; the path was not.This requires an ASGI server that forwards a request-target lacking a leading
/intoscope["path"].Impact
Any application running an affected version that uses
request.url,request.url.netloc, orrequest.url.hostnamefor a security-sensitive decision (host-based authorization, redirect/callback base, SSRF target, cache key, audit log) may be affected, when no fronting proxy or load balancer rejects the malformed request-target first.Note that this is less exploitable than GHSA-86qp-5c8j-p5mr: there, the poison is carried in the
Hostheader, so the real path still routes to a valid endpoint whilerequest.url.pathlies. Here, the poison must be carried in the path itself, and that path (@google.com) does not match any registered route, so routing returns404and no endpoint handler runs. The exposure is limited to code that readsrequest.urlbefore routing - notably middleware - or in 404/exception handlers.Mitigation
Upgrade to a patched version, which prevents the request path from crossing into the URL authority. The request above instead yields
http://localhost/@​google.comwithrequest.url.hostname == "localhost".Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:L/A:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Starlette: request.form() limits silently ignored for application/x-www-form-urlencoded enable DoS
CVE-2026-54283 / GHSA-82w8-qh3p-5jfq
More information
Details
Summary
request.form()acceptsmax_fieldsandmax_part_sizeto bound resource consumption while parsing form data. These limits are enforced formultipart/form-data, but silently ignored forapplication/x-www-form-urlencoded. An unauthenticated attacker can therefore send a urlencoded body with an arbitrarily large number of fields or an arbitrarily large field, even when the application configured limits it believed would apply.Details
request.form()dispatches to a different parser depending on theContent-Type. Formultipart/form-datathemax_files,max_fields, andmax_part_sizelimits are forwarded to the parser, but forapplication/x-www-form-urlencodedthe parser is constructed without them. It has nomax_fieldsormax_part_sizeparameter to receive them, and it appends every field with no count check and accumulates each field's name and value with no size check. The configured limits are therefore both unreachable and unenforced for url-encoded bodies.Because the url-encoded parser does its work synchronously between stream reads, the two attack shapes have different effects:
f0=v&f1=v&...) blocks the worker's event loop for several seconds while parsing, during which the worker serves no other request.FormData, forcing memory allocation proportional to the request body.The equivalent
multipart/form-datarequest is correctly rejected with400 Too many fields/400 Field exceeded maximum size.Impact
This Denial of service (DoS) vulnerability affects all applications built with Starlette (or FastAPI) that call
request.form()onapplication/x-www-form-urlencodedrequests. A single request with a very large number of fields blocks the event loop for several seconds, and a single request with a very large field forces unbounded memory allocation; in either case, parallel requests can render the service unusable. A reverse proxy that enforces a request body size limit reduces but does not eliminate the exposure, since a sub-10MB body is already enough to block the event loop.Mitigation
Upgrade to a patched version, which forwards
max_fieldsandmax_part_sizeto the url-encoded parser and enforces them while parsing, raising before the oversized field or excess fields are accumulated. The defaults matchmultipart/form-data(max_fields=1000,max_part_size=1MB) and can be customized viarequest.form(max_fields=..., max_part_size=...).Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:HReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
Kludex/starlette (starlette)
v1.3.1: Version 1.3.1Compare Source
What's Changed
StarletteDeprecationWarninginstead ofDeprecationWarningby @Kludex in #3119max_fieldsandmax_part_sizeinFormParserby @Kludex in #3329FormParserlimits in parser callbacks by @Kludex in #3331Full Changelog: Kludex/starlette@1.3.0...1.3.1
v1.3.0: Version 1.3.0Compare Source
What's Changed
FileResponseby @jiyujie2006 in #3307OSErroralongsideMultiPartExceptionwhen closing temp files by @N3XT3R1337 in #3191httpx2to thefullextra by @Kludex in #3323removeprefixto strip weak ETag indicator inis_not_modifiedby @gnosyslambda in #3193request.urlfrom structured components by @Kludex in #3326New Contributors
Full Changelog: Kludex/starlette@1.2.1...1.3.0
v1.2.1: Version 1.2.1Compare Source
What's Changed
httpx2for type checking in thetestclientmodule by @leifwar in #3304New Contributors
Full Changelog: Kludex/starlette@1.2.0...1.2.1
v1.2.0: Version 1.2.0Compare Source
What's Changed
Full Changelog: Kludex/starlette@1.1.0...1.2.0
v1.1.0: Version 1.1.0Compare Source
What's Changed
"application/octet-stream"as theFileResponsemedia type fallback by @ATOM00blue in #3283HTTPEndpointby @Kludex in #3286StaticFiles.lookup_pathby @Kludex in #3287New Contributors
Full Changelog: Kludex/starlette@1.0.1...1.1.0
v1.0.1: Version 1.0.1Compare Source
What's Changed
Hostheader when constructingrequest.urlby @Kludex in #3279Full Changelog: Kludex/starlette@1.0.0...1.0.1
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.