fix: [SDK-4341] populate push token from raw subscription for local-id models

[sherwinski]

Description

1 Line Summary

Fix subscriptions created with no push token when login() is called before optIn().

Details

When login() creates a placeholder SubscriptionModel with a local- id and empty token: '', the subsequent optIn() flow obtains the real push token via rawPushSubscription. However, Branch 2 of updatePushSubscriptionModelWithRawSubscription was calling createSubscribedUser(pushModel) with the stale empty-token model, discarding the rawPushSubscription entirely:

// Branch 2 (before fix): rawPushSubscription is never used
if (IDManager._isLocalId(pushModel.id)) {
  return createSubscribedUser(pushModel); // pushModel.token is '' from login() placeholder
}

The fix extracts the model-update logic into updateModelFromRawSubscription() and calls it before createSubscribedUser() in the local-id branch, ensuring the token, web_auth, and web_p256 fields are populated from the actual push subscription data.

Systems Affected

• WebSDK
• Backend
• Dashboard

Validation

Tests

Info

• Added a new unit test should populate token from rawPushSubscription when model has local id and empty token (SDK-4341) that reproduces the exact bug conditions: a model with a local- id and token: '' (the realistic state produced by login()). This test failed before the fix and now passes.
• Updated the existing should create user if push subscription model has a local id test to expect the web_auth and web_p256 fields that are now correctly populated from the raw subscription.

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

N/A — internal logic fix with no UI changes.

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

• SDK-4341

---

[fadi-george]

whats the original issue? is it just this "login() is called before optIn()."?

[sherwinski]

whats the original issue? is it just this "login() is called before optIn()."?

Yes, specifically login() has to fail/retry or there has to be some latency in the response. login() creates a placeholder model with token: '', and if Branch 2 of updatePushSubscriptionModelWithRawSubscription is reached (model still has a local- id), the actual token from the push subscription is discarded.

It's difficult to reproduce manually which is why I'm basing the fix off of unit tests.

[fadi-george]

Include ticket id in pr title.

[fadi-george]

We need more details from the customer.

[sherwinski]

Closing for now until we hear back