Repository navigation
fix: cancel failed archive Range reads before decoder cleanup - #138
Merged
Merged
Conversation
…-range-cancellation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached ZIP Range failures could leave synchronization waiting indefinitely for decoder cleanup. Abort the archive transport and SDK-owned output before awaiting cleanup, and pass that transport signal to storage writes waiting for capacity. Failed synchronization preserves its contiguous checkpoint and resumes through cache bypass.
The reader covers zip.js byte and streaming reads. It rejects invalid prefetched responses immediately, before a queued decoder or storage sink reads the body. Its controller stays local to the archive transport so failed cached setup can still fall back to the origin. Non-206 responses report HTTP status before cache ETag validation.
Validation on Oracle Linux arm64, Node 24.21.0:
0673119(4 failures) and pass at511cf77: cached HTTP/ETag/network errors and origin HTTP failure. They verify rejection, cache bypass where applicable, no commit or post-return writes, and successful retry.03875d1.Earlier validation at
0673119also covered SIGKILL recovery (13 uncheckpointed files retransmitted) and independent 281/562 MiB archive memory cases (maximum 364.89 MiB across six cache/single/dual cases). Full Hipo validation of the new joint candidate is tracked in https://github.com/Ontos-AI/hipo/pull/402; those SDK-only numbers do not establish Hipo's memory ceiling.Includes a patch Changeset. No public API or snapshot/checkpoint format change. Package publication and production deployment are separate release steps.
Release acceptance update:
2.6.1-beta.20261027152313; its GitHub tag and notes identifye367de113b2d79ee9a344e174e06bfaa18646833. The earlier mistagged snapshot is marked superseded and preserved for audit.Merged-main acceptance:
2.7.1-beta.20261027164158from03875d16e83123e0bde5a4d5d9fa465399bdf2ed; tag provenance verified. Full Hipo acceptance of this later beta is tracked separately before the stable release.