Skip to content

Treat unreachable memory search and send as warnings - #178

Merged
EricNGOntos merged 1 commit into
mainfrom
feat/wuchengke/memory-fail-warning
Sep 20, 2026
Merged

EricNGOntos merged 1 commit into
mainfrom
feat/wuchengke/memory-fail-warning

Conversation

@EricNGOntos

Copy link
Copy Markdown
Contributor

Summary

  • Memory search failures now return a warning to the model and are logged as warnings, with a TODO until Memento is deployed.
  • Memory send failures keep the existing warning log and add the matching TODO.
  • Online chat still continues if memory cannot be reached.

Test plan

  • Focused vitest on harness + memory-text + commit-turn
  • tsc --noEmit
  • eslint on changed files
  • After merge, confirm SaaS release tag is created

Made with Cursor

Online chat can call Memento before it is deployed; keep the turn going and mark those misses for later.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
knowhere-notebook-staging Ready Ready Preview Sep 20, 2026 4:08am UTC
1 Skipped Deployment
Project Deployment Actions Updated
knowhere-notebook Ignored Ignored Sep 20, 2026 4:08am UTC

Request Review

@EricNGOntos
EricNGOntos merged commit a63e1c9 into main Sep 20, 2026
7 checks passed
@EricNGOntos
EricNGOntos deleted the feat/wuchengke/memory-fail-warning branch September 20, 2026 04:10

This branch was successfully deployed

1 active deployment
Preview – knowhere-notebook-staging — 712960b3 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant