Repository navigation
fix: adapt Notebook to shared Knowhere demo corpus - #185
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Knowhere shared demo catalog changed its example citation payload. Notebook still required the legacy nested
sourceobject,canonical_chunk_id, andchunk_typefields, so the guest homepage failed during server rendering withExpected non-empty string from Knowhere demo API.Changes
page_numbervalues and default missing chunk types totext.Verification
pnpm vitest run src/integrations/knowhere-demo.test.tspnpm test— 836 passed, 14 skippedpnpm lintpnpm typecheckpnpm build