Repository navigation
feat: publish progressive ingestion snapshots atomically - #478
Merged
Merged
Conversation
|
|
||
| from alembic import op | ||
|
|
||
| revision: str = "9c0d1e2f3a4b" |
| from alembic import op | ||
|
|
||
| revision: str = "9c0d1e2f3a4b" | ||
| down_revision: str = "8b9c0d1e2f3a" |
| def build_raw_key(self, *, job_id: str, relative_path: str, raw_prefix: str | None = None) -> str: ... | ||
| def build_raw_key( | ||
| self, *, job_id: str, relative_path: str, raw_prefix: str | None = None | ||
| ) -> str: ... |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progressive ingestion publishes a readable baseline, then runs durable automatic enhancement under the same business Job. Keep that baseline searchable until all scopes, required vectors, and the immutable final archive are ready; publish the final content/index, snapshot pointer, and completion event together.
The implementation and acceptance references are in
docs/design/progressive-ingestion-development-plan.md, its hardening plan, and ADRs 0011–0022.Verification
make checkpassed.Deployment notes
Two append-only migrations add scope claim generations and the pending-enhancement recovery index. Existing API defaults remain
ingestion_mode=full; progressive uses the existing mode selector. Deploy compatible server snapshot/callback contracts before publishing the SDK and enabling Hipo's matching dependency. Hipo must retain the baseline until its final local copy commits.Related SDK: Ontos-AI/knowhere-node-sdk#139
Checklist
Additional baseline checks: the shared suite reports 277 passed and 4 failures; all four failures reproduce against an independent main (
eca92766) source copy and are pre-existing. API and Worker suites must run sequentially locally because the existing harness shares filesystem object storage and Redis state.Related Hipo integration: https://github.com/Ontos-AI/hipo/pull/408 (Draft until compatible SDK publication/pin).
CodeQL's assertion-side-effect finding was fixed by moving the database call out of the assertion; its focused contract passes. Alembic's revision metadata and a Protocol ellipsis are informational scan notes.