fix: instances create — flag forwarding, TTY check, complete config#212
Merged
0xmrpeter merged 4 commits intoOpen-ACP:developfrom Apr 6, 2026
Merged
Conversation
Top-level extractInstanceFlags strips these flags before passing args to cmdInstances, so cmdInstancesCreate never receives them. Re-inject parent flags into subArgs when dispatching to create subcommand.
Prevents interactive update prompt from blocking when CLI is invoked programmatically (e.g. from Tauri app via invoke_cli).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
openacp instances createwhen invoked programmatically (e.g. from OpenACP Desktop app via Tauri).--dir/--from/--nameflags: top-levelextractInstanceFlagsstrips these before passing args tocmdInstances, socmdInstancesCreatenever received them. Re-inject parent flags into subArgs.checkAndPromptUpdatenow checksprocess.stdin.isTTYto avoid blocking when CLI is invoked without interactive stdin.config.jsonnow includeschannels.sse.enabled,defaultAgent(defaults to "claude"),workspace.baseDir, andinstanceName— matching whatopenacp setupproduces.Test plan
openacp instances create --dir /tmp/test --no-interactive --jsonsucceedsopenacp start --dir /tmp/test --daemonstarts without config validation errors