Repository navigation
ci: download the OMG corpora before the OpenSysML mirror run; document the .kpar route - #10
Merged
Merged
Conversation
The advisory job built OpenSysML against these libraries without the pilot corpora, so TestKerMLFeatureMetaclassClassification failed on every run reading examples/pilot-corpora. Fetch the training and pilot corpora as OpenSysML's own CI does and fail early when a root is empty. Also document the project-interchange route for OpenSysML in the README: the release .kpar beside the model or under -library-root. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: jason.han <hanhuijun@gmail.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The advisory
OpenSysML against these librariesjob has failed on everymainrun: it builds and tests OpenSysMLdevelopwith these libraries swapped in, but never fetched the OMG corpora, soTestKerMLFeatureMetaclassClassification(which readsexamples/pilot-corpora/kerml-examples/Vehicle Example/VehicleUsages.kerml) died on a missing file before any library-related assertion ran.ci.yml: before the mirror run, cache and download the training corpus and the three pilot corpora with OpenSysML's ownscripts/download-training-examples.sh/scripts/download-pilot-corpora.sh, and fail the step when any root has no.sysml/.kermlfile — the same sequence OpenSysML'spr.ymluses. With the corpora present,go test ./internal/semantic/semantics -run TestKerMLFeatureMetaclassClassificationpasses ondevelop(v0.10.1-1266-gdada45c11); the mirror run'sgo testgets-timeout 60mbecauseinternal/exec/runtimeandinternal/exec/smtexceed the default 10m.README.md: under Using the libraries → OpenSysML, say how to use a newer revision than the one OpenSysML bundles now that it reads project interchange archives — the release.kparbeside the model (sysml -validate model.sysml opensysml-extension-libraries.kpar) or under-library-root. Both verified against the same build with ascripts/build-kpar.pyarchive: all 16 packages resolve.No library or
engine-contract.jsonchange; the pin in OpenSysML (5134a14) still matchesmainbyte for byte.Semver impact: PATCH (documentation and CI only; no library, element or contract name changes). It does not by itself require a release.
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/592f0a4104734a8292f7bd8111e3c3a5
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/592f0a4104734a8292f7bd8111e3c3a5?variant=devin
Requested by: @HuiJun