Repository navigation
feat(DiagramLayout): Route.general names the general a specialization edge is routed to - #7
Merged
Merged
Conversation
… edge is routed to A specialization is a clause of its specific element, not an element of its own, so a Route about it had nothing to name. A Route about the specific element now types general with the element the line is drawn to, `ref :>> general : Sup;`, one Route per general; a Route naming no general steers the annotated element's own edge as before. Semver minor. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
6 tasks done
Contributor
Author
|
The required check (Validate the extension libraries) is green. The advisory "OpenSysML against these libraries" job is red on two tests that do not touch this change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A SysML v2 specialization (
part def Sub :> Sup;) declares no element of its own, sometadata DiagramLayout::Route about …had nothing to name for the inheritance line a tree diagram draws — a Cameo BDD's generalization routes could not be carried into the migrated model.RoutegainsA Route about the specific element typing
generalsteers the edge drawn to that general, one Route per general; a Route withoutgeneralkeeps steering the annotated element's own edge (aconnection def Sub :> Basestill routes its own line):The typed-redefinition form is the one
MigrationMetadata::DeferredEventalready uses forsignal; a value binding (general = Detector) is not a valid feature value for the pilot, and a standalone KerMLspecializationmember is not admitted in SysML v2 textual notation, so neither was an option.engine-contract.jsonlistsgeneralonDiagramLayout::Routeand the new elementDiagramLayout::Route::general, both read byinternal/semantic/semantics/layout.goin the OpenSysML pull request that re-pins this change (Open-MBEE/OpenSysML#1166). Additive: semver MINOR,contractunchanged.Verified:
./scripts/validate-libraries.sh— 0 errors, 0 warnings on the pinned pilot (2026-08, 0.62.0);./scripts/check-engine-contract.sh --base origin/mainclean;./scripts/check-readme-table.shclean; the example above validates with 0 errors under the pilot with this library and under OpenSysML.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/850d56a6ed3e4b39b7a1dc2b4b9ec6d8
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/850d56a6ed3e4b39b7a1dc2b4b9ec6d8?variant=devin
Requested by: @HuiJun