Repository navigation
fix(verification): WP-A review follow-ups — tighter verdicts, typed TPMs, case IDs - #30
Draft
devin-ai-integration[bot] wants to merge 2 commits into
Draft
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
… IDs Review follow-ups: MissionValidation, GroundProceduresDemo, PowerAnalysis and ProximityNavigationTest now check every requirement their objective verifies; TS-008 uses a strict bound with the estimate below it; TPMs are ISQ-typed (MassTpm, PowerTpm, DurationTpm); verification usages carry VC-nnn short names. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…ginal Co-Authored-By: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to the Devin Review findings on #8 (merged), on the merged
developtree.verifys:MissionValidationtakes the achieved mass uncertainty, shown impact probability, deflection accuracy and target cases covered;GroundProceduresDemotakesscreenedArcFraction(impactScreening);PowerAnalysisalso tests TS-003's thrust/coast/proximity/reserve allocations againsttethys.nominalDuration;ProximityNavigationTesttakesmeasuredVelocityError(1 mm/s).TS-008 earthImpactExclusionis a strict bound (< 1.0e-6, as its text says) andmissionMeasures.earthImpactProbabilityis the estimate 4.0e-7, not the boundary;ReturnSafetyAnalysismatches.MassTpm,PowerTpm,DurationTpm(allocated / CBE / contingency / predicted /marginFraction) replace theReal+ unit-stringTechnicalPerformanceMeasure;MarginAtLeasttakes the margin.<'VC-001'>…<'VC-033'>short name.docs/findings/WP-A.md, probemodel/probes/F-A07-derivation-walk-original-metadata.sysml): the DocumentQueries "derivation" walk returns nothing when the original requirement itself carries@original;— which is whyVvMatrix.derivedFromis empty for the L2 rows but populated for L3/L4. Model unchanged (the connections and@originalannotations are asRequirementDerivationrecommends).Gates on this head with OpenSysML
develop0a5fa2d:make validate(7 s),make pilot(both tiers; the only pilot warnings are pre-existing ones inmodel/32-budgets.sysml),make house-rules(0 violations),tpm-margins5/5,verification-cases33/33 pass,make runs(onlyhouse-rules,render-allandviews/TethysVerification.verificationCases.mmdmove). Thecheckworkflow is still red at the OpenSysML installer step.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/ad3324581047419c950d8a0900872041
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/ad3324581047419c950d8a0900872041?variant=devin
Requested by: @HuiJun