Repository navigation
fix(as-built): bind disposal requirements to gauged data and type the quantities - #31
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
… quantities TS-291 reads the DRO-insertion xenon gauge and Argent's as-built dry mass instead of fixed 540 kg / 5638.4 kg literals; TS-292 compares the closeout passivation delay against its 30 d deadline; TS-293 and SeparationDeltaV use ImpulseValue/MassValue/SpeedValue with unit literals; Wren's as-built wetMass is the weighed 24.9 kg with designMass 24.0 kg kept separately. The disposal-requirements run imports the telemetry before evaluating. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
Closing: this branch was cut from the pre-integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2 addressing the four review findings on
model/95-as-built.sysmlandmodel/97-disposal.sysml.disposalPropellantReserveread nothing from the imported data:xenonReservewas unvalued anddeltaVCapabilityused literal540.0/5638.4. Now%import data/argent-telemetry.csv); thedisposal-requirementsrun now goes through the REPL import first and records 2601 m/s against the 270 m/s bound. Without the import the CLI reports itnot covered(xenonRemaining has no value), which is the correct standing for an in-flight requirement with no data.passivation:deadline(30 d) was declared but unused. AddedpassivationDelay = closeout.passivationCompleteTime - closeout.disposalBurnTime(23 d) andpassivationDelay <= deadlineto the constraint.separationSafety/SeparationDeltaV: bareRealreplaced byImpulseValue(25.0 ['N⋅s']),MassValue(… [kg]) andSpeedValue, bound1.0e-3 ['m/s'].wrenFM.wetMassis now the weighed24.9 [kg]anddesignMassan explicit24.0 [kg](it wasdesignMass = wetMasswithwetMasspinned to the design value, so consumers of the flight unit'swetMassundercounted by 0.9 kg).asMeasuredMass,massDeviation(3.75 %) and waiver TW-001 are unchanged.Behaviour changes
runs/disposal-requirements.txtis re-recorded through the REPL import path;as-built-satisfy,requirements-satisfy,wpb-budgets-satisfymove by one element ID (new attributes in TS-291) andhouse-rulesby the census count only.Gate
make checkgreen locally (strict validate,pilot-mission,pilot-all, house rules 0 violations / 0 unevaluated,runs-check) with OpenSysMLv0.10.1-2054-g0a5fa2d94and the pinned pilot validators. Draft until thecheckworkflow is green.Backbone
The
checkworkflow now builds OpenSysML from source intobuild/opensysml-src, butmake checkstill defaults toSYSML ?= build/opensysml/sysml, so the job fails atmake: build/opensysml/sysml: No such file or directory— identical to the latest develop run (69b2ebb). Eithercheck.ymlpassesSYSML=build/opensysml-src/bin/sysmlor the Makefile default moves; not changed on this branch.