Skip to content

WP-J: review follow-ups to safety, risk and allocations - #32

Draft
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/safety-risk-allocations-review
Draft

devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/safety-risk-allocations-review

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Fix-forward for the Devin Review findings on #3 (merged); WP-J files only.

  • TethysSafety::envelopeCases reads bagDiameter from argent.captureSystem.maximumBodyDiameter and the nominal case from TethysEnvironment::amaranth.meanDiameter instead of the literals 10 m / 6.8 m; EnvelopeMargin now takes LengthValues, and smallCaseFits / nominalCaseFits / largeCaseFits / largeCaseMarginAsSized are asserted (a smaller bag now turns the gate and TethysRisk::marginIndicators::envelopeMarginFlag red).
  • reliabilityBudget durations are DurationValues ([d] exposures, [h] MTTFs); Reliability takes the dimensionless ratio, which the unit system converts (2.0e6 h / 2200 d = 37.9, checked).
  • TH-001 gets the two missing #causation paths (returnTrajectoryInsideCorridor, lossOfThrustOnFinalArc → earthImpact).
  • riskRegister::noUnownedRedRisk covers all six entries.
  • softwareHosting.safetyCriticalSoftwareFunctions = 3, matching safetyCriticalSoftware and the three SoftwareFunctions.
  • RiskRegisterView renders asElementTable with columnViews for score, rating, status (standard Views). OpenSysML's CSV render ignores the column views and still emits the element dump → new finding F-J04 in docs/findings/WP-J.md; the construct stays as the standard answer to "one row per risk with its priority".

make check green locally (OpenSysML develop at 0a5fa2d94, v0.10.1-2054-g0a5fa2d94; two-tier pilot); runs/ re-recorded — shared runs (house-rules, list-views, render-all, views/) change only by the new TethysRisk view elements. Coverage table rows SE-081, SE-171, SE-175, SE-241 updated.

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/8068d7ebc7c04a7e815067058f991174
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/8068d7ebc7c04a7e815067058f991174?variant=devin
Requested by: @HuiJun

…ull-register red-risk gate, hazard cause paths, register table columns

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant