Repository navigation
WP-J: review follow-ups to safety, risk and allocations - #32
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ull-register red-risk gate, hazard cause paths, register table columns Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix-forward for the Devin Review findings on #3 (merged); WP-J files only.
TethysSafety::envelopeCasesreadsbagDiameterfromargent.captureSystem.maximumBodyDiameterand the nominal case fromTethysEnvironment::amaranth.meanDiameterinstead of the literals 10 m / 6.8 m;EnvelopeMarginnow takesLengthValues, andsmallCaseFits/nominalCaseFits/largeCaseFits/largeCaseMarginAsSizedare asserted (a smaller bag now turns the gate andTethysRisk::marginIndicators::envelopeMarginFlagred).reliabilityBudgetdurations areDurationValues ([d]exposures,[h]MTTFs);Reliabilitytakes the dimensionless ratio, which the unit system converts (2.0e6 h / 2200 d = 37.9, checked).#causationpaths (returnTrajectoryInsideCorridor,lossOfThrustOnFinalArc→earthImpact).riskRegister::noUnownedRedRiskcovers all six entries.softwareHosting.safetyCriticalSoftwareFunctions= 3, matchingsafetyCriticalSoftwareand the threeSoftwareFunctions.RiskRegisterViewrendersasElementTablewithcolumnViews forscore,rating,status(standardViews). OpenSysML's CSV render ignores the column views and still emits the element dump → new finding F-J04 indocs/findings/WP-J.md; the construct stays as the standard answer to "one row per risk with its priority".make checkgreen locally (OpenSysML develop at0a5fa2d94,v0.10.1-2054-g0a5fa2d94; two-tier pilot);runs/re-recorded — shared runs (house-rules,list-views,render-all,views/) change only by the newTethysRiskview elements. Coverage table rows SE-081, SE-171, SE-175, SE-241 updated.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/8068d7ebc7c04a7e815067058f991174
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/8068d7ebc7c04a7e815067058f991174?variant=devin
Requested by: @HuiJun