Repository navigation
fix(analyses): review follow-ups — SEP power cap, derived missed-thrust inputs, flyby turn geometry, one clock per state-space run - #33
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…sed-thrust inputs, turn the flyby velocity, one clock per state-space run - ArrayPowerTrade: PowerAvailableToSep takes the SEP's maximum power and caps the power scored as thrust, so wings beyond 40 kW buy mass and cost, not days. - MissedThrustDispersion: thrustDays and nonThrustDays are derived from transferNominal and the nominal duration instead of typed constants. - InsertionDispersion: the lunar flyby turns the Moon-relative velocity by the angle its periapsis allows (FlybyTurnCosine) and the departure speed is the vector sum; the collinear subtraction passed falsely above v-inf 1.4 km/s. - Record droRevolutionRk4 and firstThrustArcRk4 in separate invocations: two -action runs share one clock and the second lost its last step (F-F07, probe model/probes/F-F07-shared-clock-stop-time.sysml). Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7, fixing the four review findings on the analysis packages. Owned files only (
model/71,model/72,model/probes/,docs/coverage/WP-F.md,docs/findings/WP-F.md, WP-F lines ofscripts/runs.sh, their runs).ArrayPowerTradescored unusable power.PowerAvailableToSepnow takesmaximumSepPowerWand returnsRealFunctions::min(array power at aphelion − housekeeping, maximumSepPowerW); the trade passesargent.sep.maximumPower. 48 kW and 70 kW both saturate the 40 kW SEP, so 70 kW now scores 2234 d (was 1860) and never wins a sweep;array48kWstays selected.MissedThrustDispersioncarried typed constants.thrustDays default = transferNominal.totalThrustDaysandnonThrustDays default = tethys.nominalDuration / 1 [d] − transferNominal.thrustDayAllowance(1134.12 / 270), so the dispersion follows the transfer analysis when the SEP or target changes.InsertionDispersionpassed falsely at high v∞. The collinear subtractionapproach − flybyΔv − escapeis replaced by the turn geometry:FlybyTurnCosine(cos δ from sin(δ/2) = 1/(1 + r v²/GM)) anddepartureSpeed = √(v_moon² + v_rel² + 2 v_moon v_rel cos δ); the reserve paysmax(departureSpeed − escape, 0). At v∞ 1.49 km/s the sample now needs 45 m/s against a 23 m/s reserve (not satisfied); below ~1.4 km/s nothing moves.FlybyDeltaVis removed (no other caller).-actions in one invocation share the clock: the second starts at the first's end time and the stop testtime + timeStep > stopTimedrops its last step (or all of them in the other order). Probemodel/probes/F-F07-shared-clock-stop-time.sysml(one-state counter, expected values in its header;runs/probe-F-F07*.txt);droRevolutionRk4andfirstThrustArcRk4are recorded in separaterunlines (tooling-dynamics-dro.txt,tooling-dynamics-thrust-arc.txt), and the arc now ends attime = 2592000 [s], mass 12433.35 kg.Behaviour changes in
runs/trades.txt,trades-sweep.txt(70 kW score),montecarlo-missed-thrust.txt(1134.12 instead of 1134.0),montecarlo-insertion.txt(one sample flips to not satisfied),house-rules.txt(+4 elements),tooling-dynamics*.txtsplit. Recorded with OpenSysML from source at develop0a5fa2d94(v0.10.1-2054), the pin of the existing runs;make checkgreen locally. Draft until thecheckworkflow is green.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/27490588e02041169fc91b2cf563f6b6
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/27490588e02041169fc91b2cf563f6b6?variant=devin
Requested by: @HuiJun