Repository navigation
fix(views): shape the document queries by metamodel kind, evaluate the mass budget, fill the mode and risk views (WP-H follow-up) - #34
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…e mass budget, fill the mode and risk views Review of the WP-H document set found five queries whose rows were not what their captions said. Segments, Items and TugSubsystems take the metamodel subtypes out again (an InterfaceUsage is a PartUsage, a Part/InterfaceDefinition is an ItemDefinition) and TugSubsystems reads the Tug definition, so all ten subsystems list; FlightPhases keeps the MissionPhase-typed occurrences in succession order and a FlightEvents list follows; Risks scans the twelve packages that carry risks, so the register fills from TethysRisk; a mass-budget section reads TethysBudgets::massBudget and the ArgentTug assemblies through Column(cell = …), so the system description shows evaluated masses and margins. The massBudget view exposes the budget and the design, and modeMachine exposes TethysModes::TugModes now that it exists. Runs re-recorded on OpenSysML v0.10.1-2054-g0a5fa2d94. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
Closing: this branch was cut from the pre-integration |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the WP-H document set (
model/91-documents.sysml,model/90-views.sysml): review found five tables whose rows were not what their captions said. All are query-shape fixes; no backbone change.WhereTypekeeps subtypes, soSegments(PartUsage) also listed the fourInterfaceUsages,Items(ItemDefinition) also listed the part and interface definitions, andTugSubsystemslisted power interfaces. Each now wraps theWhereTypeinExcept(…, exclude = WhereType(…, type = "InterfaceUsage" | ("PartDefinition", "InterfaceDefinition"))).TugSubsystemsreadsTethysTug::Tug(the definition) instead ofargent, which only owns four redefinitions → 10 rows.FlightPhaseskeepstype = "TethysMission::MissionPhase"(12 phases, in succession order) instead of everyOccurrenceUsage(which put the 16 events first); a newFlightEventsquery lists the events after the phases.RisksusesNamed(qualifiedName = ("TethysRisk", "TethysSafety", "TethysTug", … "TethysDisposal"))(12 packages) instead of four; the register now shows the sixTethysRisk::riskRegisterrisks.MassBudgetLinesandSubsystemMassesqueries useColumn(name, cell = { in row : TethysBudgets::MassBudget; row.launchMass ?? "" })to read evaluated attributes (dry 4 300.9 kg with contingency vs 5 600 kg allocation, launch mass 12 624 kg vs 17 200 kg, margins 0.30/0.36; tenArgentTugassembly masses summed from their units) in a new Mass budget section ofSystemDescription. ThemassBudgetview exposesTethysBudgets::massBudgetandTethysTugStructure::argentDesign(a standard element table lists elements; the values are in the document).modeMachineexposesTethysModes::TugModes(renders the parallel mode machine, 6 KB mermaid instead of the empty note);RiskRegisterdoc no longer says "empty until".90-views.sysmlstays mission tier (TethysBudgets,TethysTugStructure,TethysModesare mission-tier packages).scripts/runs.shdocument-queriesadds the two new queries;docs/coverage/WP-H.mdcounts 15 queries and theExcept/WhereName/Column(path|cell)operations.Gate:
make checkexit 0 with defaults (validate strict,pilot-mission,pilot-all, house rules19245 elements, 173573 checks, 0 violations, 0 unevaluated,runs-check). Runs re-recorded on OpenSysMLv0.10.1-2054-g0a5fa2d94(develop's pin);git diff --stat runs/touches only WP-H outputs plus the house-rules count line.Draft until the
checkworkflow is green on the head.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/1089bee318e34e66b682fe09ad0e989d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/1089bee318e34e66b682fe09ad0e989d?variant=devin
Requested by: @HuiJun