Skip to content

fix(views): shape the document queries by metamodel kind, evaluate the mass budget, fill the mode and risk views (WP-H follow-up) - #34

Closed
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/views-documents-review
Closed

devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/views-documents-review

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Follow-up to the WP-H document set (model/91-documents.sysml, model/90-views.sysml): review found five tables whose rows were not what their captions said. All are query-shape fixes; no backbone change.

  • Metamodel subtypes taken out again. WhereType keeps subtypes, so Segments (PartUsage) also listed the four InterfaceUsages, Items (ItemDefinition) also listed the part and interface definitions, and TugSubsystems listed power interfaces. Each now wraps the WhereType in Except(…, exclude = WhereType(…, type = "InterfaceUsage" | ("PartDefinition", "InterfaceDefinition"))). TugSubsystems reads TethysTug::Tug (the definition) instead of argent, which only owns four redefinitions → 10 rows.
  • Timeline in flight order. FlightPhases keeps type = "TethysMission::MissionPhase" (12 phases, in succession order) instead of every OccurrenceUsage (which put the 16 events first); a new FlightEvents query lists the events after the phases.
  • Risk register scans the packages that carry risks. Risks uses Named(qualifiedName = ("TethysRisk", "TethysSafety", "TethysTug", … "TethysDisposal")) (12 packages) instead of four; the register now shows the six TethysRisk::riskRegister risks.
  • Mass budget with numbers. New MassBudgetLines and SubsystemMasses queries use Column(name, cell = { in row : TethysBudgets::MassBudget; row.launchMass ?? "" }) to read evaluated attributes (dry 4 300.9 kg with contingency vs 5 600 kg allocation, launch mass 12 624 kg vs 17 200 kg, margins 0.30/0.36; ten ArgentTug assembly masses summed from their units) in a new Mass budget section of SystemDescription. The massBudget view exposes TethysBudgets::massBudget and TethysTugStructure::argentDesign (a standard element table lists elements; the values are in the document).
  • Hooks consumed. modeMachine exposes TethysModes::TugModes (renders the parallel mode machine, 6 KB mermaid instead of the empty note); RiskRegister doc no longer says "empty until".

90-views.sysml stays mission tier (TethysBudgets, TethysTugStructure, TethysModes are mission-tier packages). scripts/runs.sh document-queries adds the two new queries; docs/coverage/WP-H.md counts 15 queries and the Except/WhereName/Column(path|cell) operations.

Gate: make check exit 0 with defaults (validate strict, pilot-mission, pilot-all, house rules 19245 elements, 173573 checks, 0 violations, 0 unevaluated, runs-check). Runs re-recorded on OpenSysML v0.10.1-2054-g0a5fa2d94 (develop's pin); git diff --stat runs/ touches only WP-H outputs plus the house-rules count line.

Draft until the check workflow is green on the head.

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/1089bee318e34e66b682fe09ad0e989d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/1089bee318e34e66b682fe09ad0e989d?variant=devin
Requested by: @HuiJun

…e mass budget, fill the mode and risk views

Review of the WP-H document set found five queries whose rows were not what their
captions said. Segments, Items and TugSubsystems take the metamodel subtypes out again
(an InterfaceUsage is a PartUsage, a Part/InterfaceDefinition is an ItemDefinition) and
TugSubsystems reads the Tug definition, so all ten subsystems list; FlightPhases keeps the
MissionPhase-typed occurrences in succession order and a FlightEvents list follows; Risks
scans the twelve packages that carry risks, so the register fills from TethysRisk; a
mass-budget section reads TethysBudgets::massBudget and the ArgentTug assemblies through
Column(cell = …), so the system description shows evaluated masses and margins. The
massBudget view exposes the budget and the design, and modeMachine exposes TethysModes::TugModes
now that it exists. Runs re-recorded on OpenSysML v0.10.1-2054-g0a5fa2d94.

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Closing: this branch was cut from the pre-integration wp/ head and recorded on an unpinned OpenSysML build, and it now conflicts with develop, where the integrated model and its runs are recorded at the pinned tool. The findings it addresses were re-adjudicated against the integrated model; the generally applicable fixes from here are being carried into develop on follow-up branches off develop, credited to this PR. The remaining items are design decisions being taken separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant