Repository navigation
fix(tug): address review findings on the Argent unit tree - #36
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ngs and drives; xenon tank waiver Review findings on the Argent unit tree: perform functions.captureBody moves from structure to captureSystem; SolarArrayWing and ArrayDriveMechanism require one of two installed (a wing loss degrades thrusting time, a seized drive leaves the other wing tracking), so the reliability budget treats them as one-of-two; xenonTanks keep both needed for the load and carry a SinglePointWaiver with the rationale. runs/ re-recorded with OpenSysML v0.10.1-2054-g0a5fa2d94. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the WP-B tug structure (#10) addressing the review findings on it:
perform functions.captureBodymoves fromstructuretocaptureSystem, whose bag, booms and winches implement it (one subsystem per function kept).SolarArrayWingandArrayDriveMechanismnowrequired = 1of the two installed: one wing sustains the bus and half-power thrusting, a seized drive leaves its wing fixed with the other tracking. The reliability budget treats both as one-of-two;runs/wpb-reliability.txtmoves accordingly.xenonTankskeeps[2]with both needed for the load, so the usage carries a@SinglePointWaiverwith its rationale, like the primary structure and the PCDU.Not fixable from WP-B's files, left as asks:
TethysFlightSegment::tugis typed by the backboneTug, sotethysSystemdoes not reachargentDesign's unit tree. Backbone one-liner:part :>> tug : TethysTugStructure::ArgentTug;inmodel/10-system.sysml.InspectorEnergyBudgetuses sizing assumptions for Wren's battery capacity and standby load because the inspector tree exposes neither; once WP-C's Wren units carry them, bind the two attributes to the tree.Gate:
make checkgreen locally (OpenSysML from source at develop 0a5fa2d94, pinned pilot);runs/re-recorded with that build.CI: the
checkworkflow is red on this head and ondevelopalike atmake check→make: build/opensysml/sysml: No such file or directory(Error 127): the OpenSysML installer now verifies and installsnightly-20261023-47a8251a8tobuild/opensysml/bin/sysml, while the Makefile's default isSYSML ?= build/opensysml/sysml. That is a backbone Makefile/workflow path fix, not a model change; this PR stays a draft until the workflow is green.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/ae456af00cd74c3f977ad3b79ea57161
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/ae456af00cd74c3f977ad3b79ea57161?variant=devin
Requested by: @HuiJun