Repository navigation
WP-C: envelope bounds angular momentum, commit uses upper-bound mass, link rates fit the transceiver - #37
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
WP-C: envelope bounds angular momentum, commit uses upper-bound mass, link rates fit the transceiver#37devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…upper-bound mass, link rates fit the transceiver Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1 for the three review findings that named a wrong result:
TethysCaptureSystem::CaptureEnvelopecomparedbody.rotationPeriodagainst a fixedminimumRotationPeriod(175 s, the nominal body's figure), so a heavier body at 252 s (800 t, 8 m ≈ 1.3 × 10⁵ N·m·s) passed although it exceeds the 6.0 × 10⁴ N·m·s despin budget. The constraint now bounds the body's angular momentum directly,0.1 * body.mass * body.meanDiameter² * 2π / body.rotationPeriod <= system.maximumAngularMomentum, andminimumRotationPeriodis gone fromCaptureMechanism(theMinimumRotationPeriodcalc stays as the derived figure). Verdicts over the five target cases are unchanged (runs/wpc-envelope-cases.txt: small/nominal hold, large/fastSpin/tumbling asserted not to); fastSpin now fails on angular momentum, which is what the case is for.TethysProximityOps::CommitDecisionignoredmassUncertaintyFraction; it now decides onupperMass = mass * (1 + massUncertaintyFraction)for both the mass and the angular-momentum terms.imageryLink/radarLinkbudgeted 2.5 Mbit/s over a 256 kbit/s transceiver; now 200 + 50 kbit/s.runs/:wpc-capture-sequence.txtand the sharednotation-readiness.txtchange only in the F-C04 error text (the first default evaluated is nowupperMass);house-rules.txtloses the two removed elements. Recorded with OpenSysML built from source atv0.10.1-2054-g0a5fa2d94, matchingruns/tool-version.txt.Validation
make check SYSML=build/opensysml-src/bin/sysmlgreen on develop 69b2ebb + this change (strict validate, both pilot tiers, house rules 19 182 elements / 0 violations, runs-check). Thecheckworkflow is red at its installer step on every head, as before.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/4539a6f541f54f5a935bc9ef7cd43ce4
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/4539a6f541f54f5a935bc9ef7cd43ce4?variant=devin
Requested by: @HuiJun