Skip to content

WP-C: envelope bounds angular momentum, commit uses upper-bound mass, link rates fit the transceiver - #37

Draft
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/c-review-fixes
Draft

devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/c-review-fixes

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #1 for the three review findings that named a wrong result:

  • TethysCaptureSystem::CaptureEnvelope compared body.rotationPeriod against a fixed minimumRotationPeriod (175 s, the nominal body's figure), so a heavier body at 252 s (800 t, 8 m ≈ 1.3 × 10⁵ N·m·s) passed although it exceeds the 6.0 × 10⁴ N·m·s despin budget. The constraint now bounds the body's angular momentum directly, 0.1 * body.mass * body.meanDiameter² * 2π / body.rotationPeriod <= system.maximumAngularMomentum, and minimumRotationPeriod is gone from CaptureMechanism (the MinimumRotationPeriod calc stays as the derived figure). Verdicts over the five target cases are unchanged (runs/wpc-envelope-cases.txt: small/nominal hold, large/fastSpin/tumbling asserted not to); fastSpin now fails on angular momentum, which is what the case is for.
  • TethysProximityOps::CommitDecision ignored massUncertaintyFraction; it now decides on upperMass = mass * (1 + massUncertaintyFraction) for both the mass and the angular-momentum terms.
  • imageryLink/radarLink budgeted 2.5 Mbit/s over a 256 kbit/s transceiver; now 200 + 50 kbit/s.

runs/: wpc-capture-sequence.txt and the shared notation-readiness.txt change only in the F-C04 error text (the first default evaluated is now upperMass); house-rules.txt loses the two removed elements. Recorded with OpenSysML built from source at v0.10.1-2054-g0a5fa2d94, matching runs/tool-version.txt.

Validation

make check SYSML=build/opensysml-src/bin/sysml green on develop 69b2ebb + this change (strict validate, both pilot tiers, house rules 19 182 elements / 0 violations, runs-check). The check workflow is red at its installer step on every head, as before.

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/4539a6f541f54f5a935bc9ef7cd43ce4
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/4539a6f541f54f5a935bc9ef7cd43ce4?variant=devin
Requested by: @HuiJun

…upper-bound mass, link rates fit the transceiver

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant