Repository navigation
fix(variants): judge power at aphelion, feed xenon to the thruster, fix readiness logic from review - #38
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
fix(variants): judge power at aphelion, feed xenon to the thruster, fix readiness logic from review#38devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ix readiness logic from review Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
Closing: this branch was cut from the pre-integration |
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9 for the Devin Review findings on it (four fixed, one answered on its thread).
TethysVariants::RetrievalArchitecture: power is judged at the target orbit's aphelion a(1 + e) = 1.065 AU (arrayPowerAtAphelion), the strings throttle to the array when it cannot hold full power (propulsionPower = if arrayPowerAtAphelion < ratedPropulsionPower ? arrayPowerAtAphelion else ratedPropulsionPower), andpowerClosesrequires the array at aphelion to keep every operating string above its minimum throttle point (minimumStringPower= 60 % of rated). The compact tug now runs at 26.45 kW instead of pretending to 26.67 kW; thrust and thrust time are the worst-case values. Both closing configurations still hold 7/7; the two studies still fail exactly their named constraint.TethysPhysics::ElectricPropulsion::XenonTransfer: the flow goes tothruster.xenonIn, notthruster.inputPower.TethysNotation::ReviewReadiness:windowIsUsablereplaceswindowIsOrdered(opens < closes and (not marginal | length >= 30 d));characterisationChosen(inspectorCarried or tugSensorsSuffice) replaces thexorthat rejected a small target flown with the inspector; the exclusive-or now states a real exclusion,berthIsExclusive(heavyLoad xor inspectorCarried— the heavy tank bay and the inspector berth are the same volume).calc def BerthIsExclusivereplacesInspectorDecisionConsistentinruns/notation-readiness.txt.baselineReadinessholds 13/13..kermlfile has no unit-literal[(both validators warn "Use #(...) for indexing" —BaseFunctions::'['is abstract in the kernel), so the library keeps SI-baseRealfeatures as its doc states, likeTethysEnvironment's GM.docs/findings/WP-G.md: evaluating(all SmallBody)->size()makes OpenSysML materialize everySmallBody, which now trips a type-mismatch inside another package's performed action; the message is pinned inruns/notation-readiness.txtand the assertions still validate.make checkgreen locally on develop at 69b2ebb (OpenSysMLv0.10.1-2054-g0a5fa2d94);runs/house-rules.txtandruns/notation-readiness.txtre-recorded, no other run changed. Draft until thecheckworkflow is green on the head.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/dc03bff5942440d287c875fe8a7751a1
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/dc03bff5942440d287c875fe8a7751a1?variant=devin
Requested by: @HuiJun