Skip to content

fix(variants): judge power at aphelion, feed xenon to the thruster, fix readiness logic from review - #38

Closed
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/variants-review-fixes
Closed

devin-ai-integration[bot] wants to merge 1 commit into
developfrom
wp/variants-review-fixes

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #9 for the Devin Review findings on it (four fixed, one answered on its thread).

  • TethysVariants::RetrievalArchitecture: power is judged at the target orbit's aphelion a(1 + e) = 1.065 AU (arrayPowerAtAphelion), the strings throttle to the array when it cannot hold full power (propulsionPower = if arrayPowerAtAphelion < ratedPropulsionPower ? arrayPowerAtAphelion else ratedPropulsionPower), and powerCloses requires the array at aphelion to keep every operating string above its minimum throttle point (minimumStringPower = 60 % of rated). The compact tug now runs at 26.45 kW instead of pretending to 26.67 kW; thrust and thrust time are the worst-case values. Both closing configurations still hold 7/7; the two studies still fail exactly their named constraint.
  • TethysPhysics::ElectricPropulsion::XenonTransfer: the flow goes to thruster.xenonIn, not thruster.inputPower.
  • TethysNotation::ReviewReadiness: windowIsUsable replaces windowIsOrdered (opens < closes and (not marginal | length >= 30 d)); characterisationChosen (inspectorCarried or tugSensorsSuffice) replaces the xor that rejected a small target flown with the inspector; the exclusive-or now states a real exclusion, berthIsExclusive (heavyLoad xor inspectorCarried — the heavy tank bay and the inspector berth are the same volume). calc def BerthIsExclusive replaces InspectorDecisionConsistent in runs/notation-readiness.txt. baselineReadiness holds 13/13.
  • The ISQ-typing finding on the KerML library is not applied: a .kerml file has no unit-literal [ (both validators warn "Use #(...) for indexing" — BaseFunctions::'[' is abstract in the kernel), so the library keeps SI-base Real features as its doc states, like TethysEnvironment's GM.
  • New finding F-G05 in docs/findings/WP-G.md: evaluating (all SmallBody)->size() makes OpenSysML materialize every SmallBody, which now trips a type-mismatch inside another package's performed action; the message is pinned in runs/notation-readiness.txt and the assertions still validate.

make check green locally on develop at 69b2ebb (OpenSysML v0.10.1-2054-g0a5fa2d94); runs/house-rules.txt and runs/notation-readiness.txt re-recorded, no other run changed. Draft until the check workflow is green on the head.

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/dc03bff5942440d287c875fe8a7751a1
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/dc03bff5942440d287c875fe8a7751a1?variant=devin
Requested by: @HuiJun

…ix readiness logic from review

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Closing: this branch was cut from the pre-integration wp/ head and recorded on an unpinned OpenSysML build, and it now conflicts with develop, where the integrated model and its runs are recorded at the pinned tool. The findings it addresses were re-adjudicated against the integrated model; the generally applicable fixes from here are being carried into develop on follow-up branches off develop, credited to this PR. The remaining items are design decisions being taken separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant