Merged
Conversation
Detect submodules in status payloads for system and libgit2 backends. Add Git plugin RPC methods for submodule list/add/update/sync/remove/is_available and expose a Submodules menubar section with actions and context menu integrations.
Replace the toast-only submodule listing with a real Submodules modal. Add refresh, update/sync all, add, and per-row open/update/sync/remove actions.
Wire Submodules modal Open action to switch the current repository to the selected submodule path via open_repo instead of opening it in the OS.
Close LFS Locks and Submodules plugin modals when repo switch events fire so dialogs never linger across repository changes.
Add animated loading indicators and aria-busy states while fetching LFS locks and submodule lists to prevent empty-looking modal states.
Expand dialog widths for Submodules and LFS Locks modals for better visibility and less cramped content.
Increase modal max width and height limits so Submodules and LFS Locks dialogs use much more screen space.
Revert Submodules/LFS modal dimensions to original values and only increase loading spinner visibility.
Increase plugin modal loading text weight/size and spinner dimensions so loading states are clearly visible.
Center loading indicators and stack text below spinner for LFS Locks and Submodules modal loading states.
Replace unreliable browser confirm with a two-step in-modal confirmation for submodule Remove actions.
Replace inline remove-confirm behavior with a dedicated confirmation dialog modal for clearer and more explicit submodule deletion prompts.
Increase vertical spacing between labels and inputs in the Add Submodule modal. Keep modal width unchanged while improving readability and reducing cramped text.
Increase inter-group spacing and enforce block input layout so labels do not collide with neighboring field borders.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82888b5f25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.