chore(deps): update concurrently to newer version#1221
Closed
wing328 wants to merge 5 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/generator-cli/src/app/services/generator.service.spec.ts">
<violation number="1" location="apps/generator-cli/src/app/services/generator.service.spec.ts:3">
P0: The mock factory wraps `concurrently` inside a module object `{ concurrently: jest.fn() }`, but the test variable `concurrently` is assigned via `jest.mocked(require('concurrently'))` which returns the entire module exports (the object), not the function itself. Calling `concurrently.mockImplementation(...)` then throws because `mockImplementation` does not exist on the wrapper object, only on the jest.fn inside it. Every test that relies on `concurrently.mockImplementation` will fail at runtime.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| @@ -1,12 +1,17 @@ | |||
| import { Test } from '@nestjs/testing'; | |||
|
|
|||
| jest.mock('concurrently', () => ({ | |||
Contributor
There was a problem hiding this comment.
P0: The mock factory wraps concurrently inside a module object { concurrently: jest.fn() }, but the test variable concurrently is assigned via jest.mocked(require('concurrently')) which returns the entire module exports (the object), not the function itself. Calling concurrently.mockImplementation(...) then throws because mockImplementation does not exist on the wrapper object, only on the jest.fn inside it. Every test that relies on concurrently.mockImplementation will fail at runtime.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/generator-cli/src/app/services/generator.service.spec.ts, line 3:
<comment>The mock factory wraps `concurrently` inside a module object `{ concurrently: jest.fn() }`, but the test variable `concurrently` is assigned via `jest.mocked(require('concurrently'))` which returns the entire module exports (the object), not the function itself. Calling `concurrently.mockImplementation(...)` then throws because `mockImplementation` does not exist on the wrapper object, only on the jest.fn inside it. Every test that relies on `concurrently.mockImplementation` will fail at runtime.</comment>
<file context>
@@ -1,12 +1,17 @@
import { Test } from '@nestjs/testing';
+
+jest.mock('concurrently', () => ({
+ concurrently: jest.fn(() => ({
+ result: Promise.resolve([]),
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Upgrade
concurrentlyto v10 and switch the generator CLI and tests to its named export. Updated Jest config to transformconcurrentlyso ESM imports work and tests pass.Dependencies
concurrentlyto^10.0.0with transitive updates:chalk@5.6.2,supports-color@10.2.2,shell-quote@1.8.4,yargs@18.0.0.Migration
concurrently(viayargs@18/string-width@7).concurrentlytotransformIgnorePatterns(done here).Written for commit 5a2bc9d. Summary will update on new commits.