Skip to content

chore(deps): update concurrently to newer version#1221

Closed
wing328 wants to merge 5 commits into
masterfrom
update-concurrently2
Closed

chore(deps): update concurrently to newer version#1221
wing328 wants to merge 5 commits into
masterfrom
update-concurrently2

Conversation

@wing328

@wing328 wing328 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Upgrade concurrently to v10 and switch the generator CLI and tests to its named export. Updated Jest config to transform concurrently so ESM imports work and tests pass.

  • Dependencies

    • Bump concurrently to ^10.0.0 with transitive updates: chalk@5.6.2, supports-color@10.2.2, shell-quote@1.8.4, yargs@18.0.0.
  • Migration

    • Requires Node 18+ for scripts using concurrently (via yargs@18/string-width@7).
    • If using Jest, add concurrently to transformIgnorePatterns (done here).

Written for commit 5a2bc9d. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/generator-cli/src/app/services/generator.service.spec.ts">

<violation number="1" location="apps/generator-cli/src/app/services/generator.service.spec.ts:3">
P0: The mock factory wraps `concurrently` inside a module object `{ concurrently: jest.fn() }`, but the test variable `concurrently` is assigned via `jest.mocked(require('concurrently'))` which returns the entire module exports (the object), not the function itself. Calling `concurrently.mockImplementation(...)` then throws because `mockImplementation` does not exist on the wrapper object, only on the jest.fn inside it. Every test that relies on `concurrently.mockImplementation` will fail at runtime.</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

@@ -1,12 +1,17 @@
import { Test } from '@nestjs/testing';

jest.mock('concurrently', () => ({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0: The mock factory wraps concurrently inside a module object { concurrently: jest.fn() }, but the test variable concurrently is assigned via jest.mocked(require('concurrently')) which returns the entire module exports (the object), not the function itself. Calling concurrently.mockImplementation(...) then throws because mockImplementation does not exist on the wrapper object, only on the jest.fn inside it. Every test that relies on concurrently.mockImplementation will fail at runtime.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/generator-cli/src/app/services/generator.service.spec.ts, line 3:

<comment>The mock factory wraps `concurrently` inside a module object `{ concurrently: jest.fn() }`, but the test variable `concurrently` is assigned via `jest.mocked(require('concurrently'))` which returns the entire module exports (the object), not the function itself. Calling `concurrently.mockImplementation(...)` then throws because `mockImplementation` does not exist on the wrapper object, only on the jest.fn inside it. Every test that relies on `concurrently.mockImplementation` will fail at runtime.</comment>

<file context>
@@ -1,12 +1,17 @@
 import { Test } from '@nestjs/testing';
+
+jest.mock('concurrently', () => ({
+  concurrently: jest.fn(() => ({
+    result: Promise.resolve([]),
</file context>

@wing328 wing328 closed this Jun 11, 2026
@wing328 wing328 deleted the update-concurrently2 branch June 11, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant