Skip to content

chore(deps): update concurrently to newer version#1222

Merged
wing328 merged 3 commits into
masterfrom
update-concurrently3
Jun 11, 2026
Merged

chore(deps): update concurrently to newer version#1222
wing328 merged 3 commits into
masterfrom
update-concurrently3

Conversation

@wing328

@wing328 wing328 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Upgraded concurrently to v10 and added a runConcurrently adapter for its ESM export, updating tests and Jest config so generator CLI runs and tests pass. Disabled Nx analytics.

  • Refactors

    • Switched service/tests to ./concurrently.adapter and extended Jest transformIgnorePatterns for concurrently, chalk, supports-color, yargs, shell-quote, tree-kill, rxjs.
  • Dependencies

    • Bumped concurrently to ^10.0.0; lockfile updates include chalk@5, supports-color@10, yargs@18, shell-quote@1.8.4.

Written for commit 134f401. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="package.json">

<violation number="1" location="package.json:91">
P1: Upgrading `concurrently` from v9 to v10 (ESM-only) breaks the test mocking setup. The test in `generator.service.spec.ts` uses `jest.mock('concurrently')` + `require('concurrently')`, which is a CJS mocking pattern. `jest.mock` does not apply when the resolved file is ESM — it only works for CJS targets. The `require('concurrently')` call on the ESM-only package will fail on Node <22.12.0 and, on Node >=22.12.0, the mock will be silently ignored.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread package.json
"commander": "8.3.0",
"compare-versions": "6.1.1",
"concurrently": "^9.0.0",
"concurrently": "^10.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Upgrading concurrently from v9 to v10 (ESM-only) breaks the test mocking setup. The test in generator.service.spec.ts uses jest.mock('concurrently') + require('concurrently'), which is a CJS mocking pattern. jest.mock does not apply when the resolved file is ESM — it only works for CJS targets. The require('concurrently') call on the ESM-only package will fail on Node <22.12.0 and, on Node >=22.12.0, the mock will be silently ignored.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 91:

<comment>Upgrading `concurrently` from v9 to v10 (ESM-only) breaks the test mocking setup. The test in `generator.service.spec.ts` uses `jest.mock('concurrently')` + `require('concurrently')`, which is a CJS mocking pattern. `jest.mock` does not apply when the resolved file is ESM — it only works for CJS targets. The `require('concurrently')` call on the ESM-only package will fail on Node <22.12.0 and, on Node >=22.12.0, the mock will be silently ignored.</comment>

<file context>
@@ -88,7 +88,7 @@
     "commander": "8.3.0",
     "compare-versions": "6.1.1",
-    "concurrently": "^9.0.0",
+    "concurrently": "^10.0.0",
     "console.table": "0.10.0",
     "fs-extra": "11.3.5",
</file context>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

@wing328 wing328 merged commit dd35ac1 into master Jun 11, 2026
7 checks passed
@wing328 wing328 deleted the update-concurrently3 branch June 11, 2026 09:59
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant