chore(deps): update concurrently to newer version#1222
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:91">
P1: Upgrading `concurrently` from v9 to v10 (ESM-only) breaks the test mocking setup. The test in `generator.service.spec.ts` uses `jest.mock('concurrently')` + `require('concurrently')`, which is a CJS mocking pattern. `jest.mock` does not apply when the resolved file is ESM — it only works for CJS targets. The `require('concurrently')` call on the ESM-only package will fail on Node <22.12.0 and, on Node >=22.12.0, the mock will be silently ignored.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| "commander": "8.3.0", | ||
| "compare-versions": "6.1.1", | ||
| "concurrently": "^9.0.0", | ||
| "concurrently": "^10.0.0", |
Contributor
There was a problem hiding this comment.
P1: Upgrading concurrently from v9 to v10 (ESM-only) breaks the test mocking setup. The test in generator.service.spec.ts uses jest.mock('concurrently') + require('concurrently'), which is a CJS mocking pattern. jest.mock does not apply when the resolved file is ESM — it only works for CJS targets. The require('concurrently') call on the ESM-only package will fail on Node <22.12.0 and, on Node >=22.12.0, the mock will be silently ignored.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 91:
<comment>Upgrading `concurrently` from v9 to v10 (ESM-only) breaks the test mocking setup. The test in `generator.service.spec.ts` uses `jest.mock('concurrently')` + `require('concurrently')`, which is a CJS mocking pattern. `jest.mock` does not apply when the resolved file is ESM — it only works for CJS targets. The `require('concurrently')` call on the ESM-only package will fail on Node <22.12.0 and, on Node >=22.12.0, the mock will be silently ignored.</comment>
<file context>
@@ -88,7 +88,7 @@
"commander": "8.3.0",
"compare-versions": "6.1.1",
- "concurrently": "^9.0.0",
+ "concurrently": "^10.0.0",
"console.table": "0.10.0",
"fs-extra": "11.3.5",
</file context>
|
🎉 This PR is included in version 2.38.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Upgraded
concurrentlyto v10 and added arunConcurrentlyadapter for its ESM export, updating tests and Jest config so generator CLI runs and tests pass. Disabled Nx analytics.Refactors
./concurrently.adapterand extended JesttransformIgnorePatternsforconcurrently,chalk,supports-color,yargs,shell-quote,tree-kill,rxjs.Dependencies
concurrentlyto^10.0.0; lockfile updates includechalk@5,supports-color@10,yargs@18,shell-quote@1.8.4.Written for commit 134f401. Summary will update on new commits.