fix: verify registered software admissions and bind measured issuance evidence - #39
Merged
Merged
Conversation
Signed-off-by: abrichr <richard.abrich@mldsai.com>
Signed-off-by: abrichr <richard.abrich@mldsai.com>
abrichr
marked this pull request as ready for review
September 9, 2026 03:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release verifier now sends registered
software-ed25519-dsse-v1bundles through the existing public-trust verifier. These bundles previously fell into the GitHub-attestation path. The correction preserves the registered keys, exact subject bytes, issuer/ref/environment constraints, and current authority and revocation checks. Profiles that require GitHub CLI still require version 2.98.0.The measured admission adapter checks one exact workflow bundle against retained trial reports, installed and published package bytes, contract openings, and SQLite idempotency records. Each trial must match its original observation row and native reports. It requires all six declared classes and rejects missing evidence or counters. Private recordings, recipes, and trial data stay outside this repository.
Signing uses the existing authority and a reviewed plan hash. Persistent request journals prevent an uncertain issuance from being retried under another handle. The staged workflow keeps storage references distinct from protected-main issuer sources; its README describes each phase and read-only reconciliation. This PR doesn't issue an admission.
The live Flow 1.34.0 check exposed an invalid historical reference and correctly refused it. Its signed acceptance-summary reference names registry revision 1 at commit
2c129702da718522cc257913207b6ed6f3b33b7c, with head9a9f597b0d87674c4d36c022227201a5d8f3072237624346793692c3a863d12e. That immutable commit contains an empty registry with head3c88a4e945f1aa51ee080f05331c0d7a36b907ad288cf8a24b2fef08b1681a97. An independent fetch of the exact public bytes and a strict replay through unchangedfetch_pair()both returnedreference registry revision or head differs. The historical signed records remain unchanged. A new admission must bind real containing commits before it can yield a valid receipt.Validation: 98 focused tests pass across the adapter, registered-profile routing, public trust, issuer, and production trust suites. Independent review repeated the routing tests and exercised real registered signatures and current trust state without a keyless fallback. The adapter review also confirmed that exchanged report references, mismatched native idempotency keys, and inconsistent SQLite reservation records refuse. Both required profile checks pass at
6eef685308a8c581905135e3e845c93b4a6754cc.