fix(mediorum): avoid blocked replication pipe goroutines#336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replicateFileToHostpipe writer goroutines from blocking forever when peer replication returns earlyContext
In production,
creator-2had ~42k goroutines, with ~41k parked inMediorumServer.replicateFileToHost.func1atpkg/mediorum/server/replicate.go:191. Those goroutines were blocked sending to an unbufferederrChanafter failed repair/replication attempts. The pod memory graph was mostly file cache, but theopenaudioheap was also inflated compared withcreator-1.The old code could return from the HTTP path before reading from
errChan, and if the peer did not consume the body or the pipe copy failed, the writer goroutine could remain blocked.Test Plan
go test -c ./pkg/mediorum/servergo test ./pkg/mediorum/server -run TestReplicateFileToHostClosesPipeOnEarlyHTTPError -count=1, but local packageTestMainrequires Postgres onlocalhost:5454; it failed before running the test with connection refused.