Merged
Conversation
lohedges
approved these changes
Mar 30, 2026
Contributor
lohedges
left a comment
lohedges
left a comment
There was a problem hiding this comment.
Great, thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the existing
ring_break_morphandreverse_ring_break_morphschedules to use Direct Morse Replacement (DMR) approach rather than the original indirect approach. Key modifications are the introduction of a "hard" and "soft" Morse bond potential restraints which are used to carry out the bond-annihilation, everything else remains unchanged.ring_break_morphschedule:reverse_ring_break_morphschedule:I have done limited single replicate testing that shows the reverse schedule gives the exact opposite answer for the CHK1 C20 --> C17 vacuum leg (when running C17 --> C20).