feat: Add CLI OIDC configuration for Tokensmith - #56
Open
alexlovelltroy wants to merge 3 commits into
Open
alexlovelltroy wants to merge 3 commits into
alexlovelltroy wants to merge 3 commits into
Conversation
- Introduced CLIOIDCConfig to TokensmithSpec for managing CLI OIDC client settings. - Implemented validation for CLI OIDC redirect URIs and assignments in webhook tests. - Enhanced deep copy functionality for CLIOIDCConfig. - Updated CRD to include CLI OIDC properties with defaults. - Added documentation for CLI OIDC testing and publishing procedures. - Modified Vault reconciler to provision both confidential and public OIDC clients. - Implemented tests for CLI client creation and validation. Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
alexlovelltroy
force-pushed
the
feature/vault-oidc-cli-client
branch
from
September 22, 2026 12:39
ff0b4de to
a229aca
Compare
- Changed the type of `rateLimitRequests` from `uint` to `uint32` for better compatibility. - Removed unnecessary variable declarations for rate limit type in `buildSMDRateLimit` function. - Updated error handling in `EnsureBucket`, `bucketReachable`, `DeleteBucket`, and `emptyBucket` methods to use `errors.AsType` for cleaner type assertions. Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
…t config Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change