Add flake.nix again by DINEXXL · Pull Request #343 · OpenCloudGaming/OpenNOW

DINEXXL · 2026-04-20T15:15:41Z

Description

I found the time to create a new flake.nix file for the new version, and I included Nix instructions in README.md

Just go along with it so there won't be any conflicts later, please

Merge Dev -> Main

Merge Developer branch into main branch

Copilot

Pull request overview

Reintroduces Nix flake support for building/running the Electron-based opennow-stable app from Nix, and documents how to consume it from a user flake.

Changes:

Adds flake.nix/flake.lock to provide a default Nix package for opennow-stable.
Documents Nix usage in README.md.
Updates opennow-stable/package-lock.json metadata and adjusts .gitignore for Nix build outputs.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
opennow-stable/package-lock.json	Updates lockfile metadata (including package version) and dependency entries.
flake.nix	Introduces a Nix flake that builds `opennow-stable` via `buildNpmPackage` and wraps it with Electron.
flake.lock	Pins nixpkgs and flake-utils inputs for reproducible flake evaluation.
README.md	Adds Nix installation/consumption instructions.
.gitignore	Ignores the Nix `result` build symlink.

Files not reviewed (1)

opennow-stable/package-lock.json: Language not supported

Copilot · 2026-04-20T16:05:26Z

 {
  "name": "opennow-stable",
-  "version": "0.3.2",
+  "version": "0.3.6",


opennow-stable/package-lock.json is currently being updated in this PR, but it’s also listed in .gitignore. Even though tracked files aren’t ignored, this is confusing for contributors and can lead to accidental local-only changes. Consider either removing this ignore entry or explicitly untracking/stop committing the lockfile (pick one consistent approach).

Copilot · 2026-04-20T16:05:27Z

+      in
+      {
+        packages.default = pkgs.buildNpmPackage {
+          pname = "opennow";
+          version = "1.0.0";


The flake package version is hardcoded to 1.0.0, which doesn’t match the app version (0.3.6 in opennow-stable/package.json). This will make Nix users/reporting/debugging inconsistent; consider aligning the flake version with the actual app version (or deriving it from the package sources).

Suggested change

in

{

packages.default = pkgs.buildNpmPackage {

pname = "opennow";

version = "1.0.0";

appPackage = builtins.fromJSON (builtins.readFile ./opennow-stable/package.json);

in

{

packages.default = pkgs.buildNpmPackage {

pname = "opennow";

version = appPackage.version;

Copilot · 2026-04-20T16:05:27Z

+            mkdir -p $out/lib/opennow
+            cp -r . $out/lib/opennow
+


The custom installPhase copies the entire build directory (cp -r .) into the output. With buildNpmPackage this typically includes the full node_modules tree (often with devDependencies) and build caches, which can massively increase closure size and make the result less reproducible. Prefer installing only the runtime artifacts needed to launch (and pruning devDependencies if possible).

Suggested change

mkdir -p $out/lib/opennow

cp -r . $out/lib/opennow

appdir="$TMPDIR/opennow-install"

mkdir -p "$appdir" "$out/lib/opennow"

if [ -f package.json ]; then

cp package.json "$appdir/"

fi

if [ -f package-lock.json ]; then

cp package-lock.json "$appdir/"

fi

for path in out dist dist-electron; do

if [ -e "$path" ]; then

cp -r "$path" "$appdir/"

fi

done

if [ -d node_modules ]; then

cp -r node_modules "$appdir/"

if [ -f "$appdir/package.json" ]; then

npm --prefix "$appdir" prune --omit=dev --no-audit --legacy-peer-deps

fi

fi

cp -r "$appdir"/. $out/lib/opennow

Copilot · 2026-04-20T16:05:28Z

+```
+
+```nix
+# Nixos configuraion


Typo: configuraion should be configuration.

Suggested change

# Nixos configuraion

# NixOS configuration

Kief5555

LGTM, waiting for AI Review

Copilot

Pull request overview

Copilot reviewed 3 out of 6 changed files in this pull request and generated 6 comments.

Files not reviewed (1)

opennow-stable/package-lock.json: Language not supported

Copilot · 2026-04-21T03:38:46Z

+              desktopName = "OpenNOW"; 
+              genericName = "Custom GeForce Now Client Named OpenNOW";
+              comment = "An open-source desktop client for GeForce NOW";
+              exec = "opennow %U";
+              icon = "opennow";
+              keywords = [ "GFN" "GeForceNOW" "cloud" "gaming" ];
+              startupWMClass = "opennow"; 
+              startupNotify = true;
+              categories = [ "Game" "Network" ];
+              mimeTypes = [ 
+                "x-scheme-handler/opennow" 
+                "x-scheme-handler/geforcenow" 


There’s trailing whitespace after values in the desktop item fields here (e.g. after desktopName / startupWMClass). It’s harmless but tends to create noisy diffs and can trip whitespace-sensitive tooling—please trim it.

Suggested change

desktopName = "OpenNOW";

genericName = "Custom GeForce Now Client Named OpenNOW";

comment = "An open-source desktop client for GeForce NOW";

exec = "opennow %U";

icon = "opennow";

keywords = [ "GFN" "GeForceNOW" "cloud" "gaming" ];

startupWMClass = "opennow";

startupNotify = true;

categories = [ "Game" "Network" ];

mimeTypes = [

"x-scheme-handler/opennow"

"x-scheme-handler/geforcenow"

desktopName = "OpenNOW";

genericName = "Custom GeForce Now Client Named OpenNOW";

comment = "An open-source desktop client for GeForce NOW";

exec = "opennow %U";

icon = "opennow";

keywords = [ "GFN" "GeForceNOW" "cloud" "gaming" ];

startupWMClass = "opennow";

startupNotify = true;

categories = [ "Game" "Network" ];

mimeTypes = [

"x-scheme-handler/opennow"

"x-scheme-handler/geforcenow"

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Kief5555 · 2026-04-22T05:11:42Z

Pending approval @zortos293 version number change?

zortos293 · 2026-04-22T10:10:30Z

@Kief5555 yes

zortos293 and others added 15 commits April 9, 2026 19:58

Merge pull request OpenCloudGaming#234 from OpenCloudGaming/dev

df73453

Merge Dev -> Main

chore(release): prepare v0.3.3

878d377

Merge pull request OpenCloudGaming#253 from OpenCloudGaming/dev

67ecbdd

chore(release): prepare v0.3.4

2ace8ca

Merge pull request OpenCloudGaming#282 from OpenCloudGaming/dev

18190f2

Merge Developer branch into main branch

chore(release): prepare v1.3.5

99d9cff

chore(release): prepare v0.3.5

4d041a4

Update README.md to include TestFlight badge and iOS packaging target

6918f58

update AGENTS.md

c022161

Merge pull request OpenCloudGaming#326 from OpenCloudGaming/dev

a34988a

chore(release): prepare v0.3.6

8460b34

Fix Nix npm packaging

bc7391c

Update

f3dc069

Add nix instruction in README.md

6c4f12d

Delete symbolic Link

dd3f55f

Kief5555 requested review from Kief5555 and Copilot April 20, 2026 16:01

Copilot started reviewing on behalf of Kief5555 April 20, 2026 16:02 View session

Kief5555 requested changes Apr 20, 2026

View reviewed changes

Comment thread flake.nix

Copilot AI reviewed Apr 20, 2026

View reviewed changes

change requested changes and add desktop items

6586821

DINEXXL requested a review from Kief5555 April 20, 2026 17:32

Kief5555 approved these changes Apr 21, 2026

View reviewed changes

Kief5555 changed the base branch from main to dev April 21, 2026 03:30

Kief5555 requested a review from Copilot April 21, 2026 03:34

Copilot started reviewing on behalf of Kief5555 April 21, 2026 03:34 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Kief5555 and others added 3 commits April 20, 2026 20:40

Update README.md

55ccfce

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update flake.nix

27af900

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update README.md

2972935

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Kief5555 requested a review from zortos293 April 22, 2026 05:11

Kief5555 merged commit 20f7766 into OpenCloudGaming:dev Apr 23, 2026
6 checks passed

-            mkdir -p $out/lib/opennow
-            cp -r . $out/lib/opennow
+            appdir="$TMPDIR/opennow-install"
+            mkdir -p "$appdir" "$out/lib/opennow"
+            if [ -f package.json ]; then
+              cp package.json "$appdir/"
+            fi
+            if [ -f package-lock.json ]; then
+              cp package-lock.json "$appdir/"
+            fi
+            for path in out dist dist-electron; do
+              if [ -e "$path" ]; then
+                cp -r "$path" "$appdir/"
+              fi
+            done
+            if [ -d node_modules ]; then
+              cp -r node_modules "$appdir/"
+              if [ -f "$appdir/package.json" ]; then
+                npm --prefix "$appdir" prune --omit=dev --no-audit --legacy-peer-deps
+              fi
+            fi
+            cp -r "$appdir"/. $out/lib/opennow

Uh oh!

Conversation

DINEXXL commented Apr 20, 2026

Description

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Kief5555 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Kief5555 commented Apr 22, 2026

Uh oh!

zortos293 commented Apr 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants