Conversation
Spec rows FND-04, FND-07, TXT-03, TXT-06 (+ TXT-04 e2e). - Drag and drop (dnd.ts): Finder rows and desktop icons are draggable; Finder lists, folder rows, the desktop and the Trash accept drops. Plain drop moves, Option/Alt-drop copies; Trash drop trashes. - Desktop (desktop-icons.ts): /Desktop as a right-aligned icon column under all windows, Trash bottom-right showing empty/full. - TextEdit: own undo/redo history (500 steps; spec asks >= 100), Edit menu, find bar with match count, Enter/Shift+Enter cycling, and a highlight layer so matches stay visible while typing in Find. Bugs found by the new tests: - Title-bar drag was hijacked by a native HTML5 drag once rows became draggable: after the first move Chromium hit-tests the original press point, now over a Finder row. preventDefault on window-drag pointerdown. - Double-clicking a desktop icon never fired: selection re-rendered the layer between clicks. Selection now toggles a class in place. - TextEdit raised a false E_CONFLICT on save after its file was renamed: rename bumps rev, not content. Metadata-only rev changes are adopted. Tests: kernel 43/43; shell e2e 29/29 (repeat x2 green; TXT-04 x16). Clean-room attestation: written from the Cauldron spec and general knowledge only; no ryOS or Puter source, DOM, CSS, or assets consulted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CI (Linux) caught WM-04: the find highlight layer made the textarea position:absolute with z-index 1, which stacked it over the window's resize grip, so TextEdit windows could not be resized by hand. The grip now sits at z-index 5; WM-04b asserts the grip is the hit target (fails without the fix, passes with it). Why local runs missed it: port 5178 is also used by Modex's Vite dev server (on ::1), and reuseExistingServer let local runs attach to whatever answered. Dev port moves to 5188 and the test server is never reused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues remain in accessibility, drag/drop behavior, and TextEdit state synchronization.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds shell drag-and-drop, desktop icons/Trash, and TextEdit undo/redo/find functionality.
Changes:
- Added Finder and desktop drag-and-drop.
- Added desktop icons and Trash state handling.
- Added TextEdit history, find highlighting, and rename tracking.
- Added E2E and screenshot coverage.
| File | Summary |
|---|---|
apps/shell/src/textedit.ts |
TextEdit history, find, highlighting, and document tracking |
apps/shell/src/slate.css |
Editor and desktop icon styling |
apps/shell/src/shell.ts |
Desktop integration and window drag handling |
apps/shell/src/finder.ts |
Finder drag/drop targets |
apps/shell/src/dnd.ts |
Shared drag/drop behavior |
apps/shell/src/desktop-icons.ts |
Desktop icons and Trash |
apps/shell/e2e/screenshots.spec.ts |
Screenshot coverage |
apps/shell/e2e/rows2.spec.ts |
Feature acceptance tests |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| this.#text.value = r.content; | ||
| this.#last = r.content; | ||
| this.#past = []; | ||
| this.#future = []; |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Builds the remaining dev-shell rows Val asked for: drag between windows, desktop icons, undo, find.
/Desktopas icons under every window; Trash bottom-right with empty/full state.Bugs the new tests caught (all fixed here)
Spec rows covered
FND-04, FND-07, TXT-03, TXT-04, TXT-06 (+ FND-04b, FND-07b, TXT-03b ≥100 steps, TXT-04b, TXT-06b).
Kernel 43/43 · shell e2e 29/29 (full suite ×2 green; TXT-04 ×16 green).
Still not built: icon view (§6.3), Shift/⌘/marquee multi-select (§6.5).
Clean-room attestation
🤖 Generated with Claude Code