Repository navigation
Give the Windows supervisor job room to finish - #325
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The workflow timeout adjustment is narrowly scoped and the governed conformance lock/test/docs repins are updated consistently with the change.
Pull request overview
This PR increases the job-level timeout for the “Windows supervisor behavior” GitHub Actions job to prevent it from being cancelled at the 20-minute cap, and then updates the Phase 1 conformance authority pinning artifacts to keep governed workflow digests and documented bindings consistent.
Changes:
- Raise
.github/workflows/ci.ymljobwindows-supervisor-behaviortimeout-minutesfrom 20 → 30. - Repin Phase 1 conformance harness authority (
revision/tree) and update the governed blob/SHA-256 entry for the changed workflow inphase1-conformance.lock.jsonand its test mirror. - Refresh the documented “reviewed source” binding in
docs/phase1-conformance.mdto match the new authority revision/tree.
File summaries
| File | Description |
|---|---|
src/phase1-conformance-lock.test.ts |
Updates the expected harness authority revision/tree and the pinned blob/SHA-256 for .github/workflows/ci.yml used by the lock tests. |
phase1-conformance.lock.json |
Repins harness.revision and harnessAuthority (revision/tree), plus the .github/workflows/ci.yml blob/SHA-256 entry to reflect the workflow change. |
docs/phase1-conformance.md |
Updates the prose binding to the new reviewed source revision/tree. |
.github/workflows/ci.yml |
Increases windows-supervisor-behavior job timeout to 30 minutes to avoid end-of-job cancellation. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The job is capped at 20 minutes and needs 18 to 20, so it dies on the cap and GitHub reports the overrun as a cancellation, which reads as a flake. It has taken out PR #313 three times and main twice, always after every assertion passed, in the final cargo check step. Raise the cap to 30. Carries every governed digest that moves with this commit. ci.yml is tracked in harnessAuthority.files, so its blob and SHA-256 advance in the lock and in the test's literal copy. Also refreshes three production deltas. Cargo.toml, Cargo.lock and keyring.rs changed in #322 without a repin, which stayed invisible while the authority still pointed at an older commit and the deltas were verified against that older tree. Advancing the authority surfaces the drift, so their digests move here rather than in the repin. Refs #324
Repin only: harness revision, harness authority revision and tree, and the prose and test copies of them. No digests and no behaviour move here; they landed with the edit itself. Refs #324
ef7bd74 to
285ced0
Compare
|
Force-pushed a correction. The first attempt failed
Their digests now move in the code commit, where digests belong, rather than in the repin. The repin still touches only the revision, the tree, and their prose and test copies. Rebuilt rather than patched on top, so the two-step shape is preserved:
Re-verified against the new authority: tree matches Two tests, |
Brings in the raised Windows supervisor timeout from #325 so this branch's own supervisor job has room to finish, and refreshes every governed digest against the merged tree: ci.yml from main, and the Cargo.toml, Cargo.lock and keyring.rs production deltas. Digests land here, with the merge that changes the files. The authority revision and tree advance in the repin that follows.
Closes #324.
Windows supervisor behavioris capped attimeout-minutes: 20and needs 18 to 20, so it dies on the cap. GitHub reports the overrun ascancelled, which reads as a flake. It has taken out #313 three times andmaintwice, always after every assertion passed, in the finalcargo checkstep.Raises the cap to 30 on that job only.
Two commits, as the protocol requires
.github/workflows/ci.ymlis one of the 25 files underharnessAuthority, so this follows the two-step indocs/phase1-conformance.md:74689b1— the edit, plusci.yml's new blob and SHA-256 in the lock and in the test's literal copy. Every digest rides with the change itself.ef7bd74— repin only:harness.revision,harnessAuthority.revision/.tree, and the prose and test copies of them. No digests, no behaviour.Verification
74689b174689b1^{tree}vitest --config vitest.heavy.config.ts src/phase1-conformance-lock.test.tspnpm exec vitest runpnpm typecheck,pnpm lintThere is a second
timeout-minutes: 20at line 129 of the same file, so the edit was made by line number rather than string match; the diff touches one line. No test pinned this job's timeout.Merge requirement
The repin points
harnessAuthority.revisionat74689b1, a commit on this branch. Perdocs/phase1-conformance.mdit must land as a real merge commit, never a squash or rebase, or the pinned revision stops being an ancestor ofmainand the authority checkout only resolves while this branch survives. An SDK rebind follows, as it does for any authority move.🤖 Generated with Claude Code