Measure overlays, hover states, menus and dialogs at WCAG AA - #392
Merged
Merged
Conversation
…schemes The rendered contrast check moves to e2e/contrast.ts and now runs with each overlay open: a hovered sidebar row, the find bar, the screen viewer, mention suggestions, the drop overlay, the chat actions menu, the delete dialog and the context picker. It waits for entry transitions to settle, and while a modal is open it reads only the modal, since the page behind is inert. The context picker is not modal, so the page behind it stays in use. Its 15% black scrim dropped light-scheme muted text to 3.76:1; on a light page the scrim is now transparent and the panel's shadow separates it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several contrast tests can pass without verifying that the intended overlays, states, and visible text are actually measured.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds rendered WCAG AA contrast checks across light/dark themes and overlay states, and removes the light-theme context-picker scrim.
Changes:
- Adds reusable screenshot-based contrast analysis.
- Covers menus, dialogs, pickers, hover states, and overlays.
- Makes the light-theme context-picker backdrop transparent.
| File | Description |
|---|---|
src/coven/context-picker.css |
Removes the light-theme picker scrim. |
e2e/contrast.ts |
Provides reusable rendered contrast analysis. |
e2e/chat-lifecycle.spec.ts |
Tests menu, dialog, and context-picker contrast. |
e2e/app.tauri-mock.spec.ts |
Tests additional overlay and hover-state contrast. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Review found the checks could pass against the plain page if an overlay failed to open. Each state now asserts its overlay is visible first. That showed mention suggestions never opened in the app fixture, which has no known context, so the check moves to the lifecycle fixture. The drop overlay is aria-hidden, and the helper skipped aria-hidden text, so its message was never read; sighted users still see it, so only inert and screen-reader-only text is skipped now. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
e2e/contrast.ts. It now runs in both colour schemes with each overlay open:Verification
playwright test: 57 passed, including all six contrast tests (3 tests × 2 schemes).vitest run src/coven src/design: 295 passed.🤖 Generated with Claude Code